opencloud-eu
[FR] Thumbnailer for HEIC
Is your feature request related to a problem? Please describe.
heic images, neither have a thumbnail nor can they be displayed. The only option available is to download them.
Describe the solution you'd like
The thumbnailer can be used to display a preview of the image, it can also be used to display a converted image in the integrated image viewer.
This is the list of formats supported by go-vips currently:
https://github.com/davidbyttow/govips/blob/36797d897bb01ecae630eafe0a2d1ce9ee3dbade/vips/foreign.go#L151
I guess we should add all of them.
IIRC the main problem is we current have a hardcoded list of supported formats somewhere in the backend (and somewhere in the frontend as well). As we have two different thumbnailer implementations (native go vs. vips C bindings) we somehow need to communicate the supported formats from the backend to the frontend(s)
Concept
Implementation
- Thumbnailer Part WIP by @micbar
- Add flag on webDAV to indicate if the server can render a thumbnail
What could also be useful would be to add a save as jpg option.
For the preview app (control bar at the bottom) or for the context menu (file list context menu, opened-file context menu in the topbar context, etc)?
What could also be useful would be to add a save as jpg option.
For the preview app (control bar at the bottom) or for the context menu (file list context menu, opened-file context menu in the topbar context, etc)?
I'd expect such functionality in the context menu and the preview app.
I know license stuff like this is annoying, but it is extremely important for the end user.
A stupid user like me does not care about licenses and stuff. I see that OneDrive, Google Photos, iCloud Photos, Dropbox, GDrive all support it. If I create a public folder for friends to drop in our pictures of our holidays together, I simply expect it to work like every other service listed. And this is not only related to private stuff, also at work, if I share a picture of a construction site with someone external, I simply expect it to be working.
Stuff like this sometimes gets overlooked. But it is simply stuff like that which can make the difference between usable and not usable for the user. What I am trying to say with way too many words is that the importance of this feature cannot be understated :)
If that means the admin has to configure imagick (Nextcloud does not enable it by default for imagick, apparently some security flaw, they use https://github.com/h2non/imaginary instead) that is totally fine.
This feature is also available in other open source tools like Nextcloud (which is using imagemagick). OCIS seems to have support for this as well: https://github.com/owncloud/ocis/issues/7373
iOS devices use this format for by default...
So what would be an individual solution, if we want to enable this in our docker environment afterwards? Can we replace / edit some configuration files? What would be a suitable solution that does not require to repack the image? Can you give us some hints how we could solve this for our individual environments?
This would be very nice!
having A LOT of heic photos, I would also be very much interested to know how I can enable this feature as I don't want to convert all my libraries into jpeg... aaah those patents ! 👎
What if we use an existing docker container that supports HEIC: https://github.com/opencloud-eu/opencloud/issues/1128
