opencloud icon indicating copy to clipboard operation
opencloud copied to clipboard

merge ocdav into frontend

Open butonic opened this issue 4 weeks ago • 2 comments

This PR moves the ocdav handler back into the frontend. This removes one usage of the go micro service.

butonic avatar Dec 02 '25 15:12 butonic

it seems reva handles a leading // differently:

  Scenario: send PROPFIND requests to webDav endpoints with 2 slashes using the spaces WebDAV API                                 # /woodpecker/src/github.com/opencloud-eu/opencloud/tests/acceptance/features/coreApiAuth/webDavSpecialURLs.feature:155
    When user "Alice" requests these endpoints with "PROPFIND" to get property "d:href" about user "Alice"                        # AuthContext::theUserRequestsTheseEndpointsToGetOrSetPropertyAboutUser()
      | endpoint                                 |
      | //dav//spaces/%spaceid%/textfile1.txt    |
      | /dav//spaces/%spaceid%/PARENT/parent.txt |
      | /dav//spaces/%spaceid%/PARENT            |
      | //dav/spaces//%spaceid%//FOLDER          |
    Then the HTTP status code of responses on each endpoint should be "200,207,207,200" on OpenCloud or "207,207,207,207" on reva # FeatureContext::theHTTPStatusCodeOfResponsesOnEachEndpointShouldBeOcReva()
      Expected HTTP status codes: "200,207,207,200". Found HTTP status codes: "405,207,207,405"
      Failed asserting that false is true.

  Scenario: send PROPPATCH requests to webDav endpoints with 2 slashes                                                 # /woodpecker/src/github.com/opencloud-eu/opencloud/tests/acceptance/features/coreApiAuth/webDavSpecialURLs.feature:165
    When user "Alice" requests these endpoints with "PROPPATCH" to set property "d:getlastmodified" about user "Alice" # AuthContext::theUserRequestsTheseEndpointsToGetOrSetPropertyAboutUser()
      | endpoint                                 |
      | //webdav/textfile0.txt                   |
      | //dav//files/%username%/textfile1.txt    |
      | /dav//files/%username%/PARENT/parent.txt |
      | /webdav//PARENT                          |
      | //dav//files/%username%//FOLDER          |
    Then the HTTP status code of responses on each endpoint should be "200,200,400,400,200" respectively               # FeatureContext::theHTTPStatusCodeOfResponsesOnEachEndpointShouldBe()
      Expected HTTP status codes: "200,200,400,400,200". Found HTTP status codes: "405,405,400,400,405"
      Failed asserting that false is true.

butonic avatar Dec 05 '25 12:12 butonic

@ScharfViktor the tests were expecting the wrong status codes. I corrected them and CI should now become green.

butonic avatar Dec 05 '25 14:12 butonic