skillful_nowcasting Extra ReLU in L Block

Extra ReLU in L Block

Open najeeb-kazmi opened this issue 1 year ago • 3 comments

https://github.com/openclimatefix/skillful_nowcasting/blob/e2d601a377613b463fcc3c7319017f8051346e8e/dgmr/common.py#L280

I believe this first ReLU should not be present in the L Block, going by the diagram in the paper (Extended Data Figure 1, page 18).

Mar 10 '23 23:03 najeeb-kazmi

Thanks @najeeb-kazmi for the question. I'll let @jacobbieker get back to you on this

Mar 24 '23 09:03 peterdudfield

@all-contributors please add @najeeb-kazmi for question

Mar 24 '23 09:03 peterdudfield

@peterdudfield

I've put up a pull request to add @najeeb-kazmi! :tada:

Mar 24 '23 09:03 allcontributors[bot]