quartz-frontend icon indicating copy to clipboard operation
quartz-frontend copied to clipboard

Update solar limit to 5000 (from 4000)

Open peterdudfield opened this issue 1 year ago • 4 comments

Currently the solar generation was very near 4000, and the graph look a bit close to the top. We could adjust the yaxis to something a bit

Here sets out a few examples of how to do it

https://stackoverflow.com/questions/50078787/recharts-set-y-axis-range

peterdudfield avatar Apr 29 '24 11:04 peterdudfield

One way to do this is with padding={{ top: 20 }}.

If we use <YAxis type="number" domain={[0, 20000]}/> I think we will always run into issues for different data at different order of magnitudes.

Screenshot 2024-04-29 at 16 39 17

peterdudfield avatar Apr 29 '24 15:04 peterdudfield

@braddf I can make a PR, but wanted to get your opinion on domain or padding or other things in https://recharts.org/en-US/api/YAxis

peterdudfield avatar Apr 29 '24 15:04 peterdudfield

@peterdudfield just looking at this now, my first impression is that padding is just the gap and I don't think it looks as nice

braddf avatar Apr 30 '24 07:04 braddf

Yea I know what you mean. I thought it would be an empty space of padding, but it looks like its padding on the Yaxis, so its maybe a bit like a buffer ontop of the maximum value.

its this bit, above 4000

Screenshot 2024-04-30 at 08 32 39

peterdudfield avatar Apr 30 '24 07:04 peterdudfield