quartz-frontend icon indicating copy to clipboard operation
quartz-frontend copied to clipboard

Issue/466 swap gsp name

Open peterdudfield opened this issue 1 year ago • 4 comments

Pull Request

Description

Swap DNO name order

before

Screenshot 2024-05-14 at 13 05 35

now Screenshot 2024-05-14 at 13 05 01

Fixes #466

How Has This Been Tested?

Looked at the new vercel branch + added some unit tests

  • [x] Yes

Checklist:

  • [x] My code follows OCF's coding style guidelines
  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have checked my code and corrected any misspellings

peterdudfield avatar Feb 06 '24 14:02 peterdudfield

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:08am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
quartz-app ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 0:08am

vercel[bot] avatar Feb 06 '24 14:02 vercel[bot]

hi @peterdudfield, I'm just having a look at this and wondering what the difference is between SSE and Southern (SSE). I probably just don't know the DNO's well enough.

rachel-labri-tipton avatar Feb 15 '24 09:02 rachel-labri-tipton

hi @peterdudfield, I'm just having a look at this and wondering what the difference is between SSE and Southern (SSE). I probably just don't know the DNO's well enough.

Yea, I'm not sure either

https://github.com/openclimatefix/quartz-frontend/issues/466

I've put all the names from the api in this issue

peterdudfield avatar Feb 15 '24 09:02 peterdudfield

@peterdudfield Is this new name format function intentionally trimming to Region names to only the first word? E.g. WPD (South West) becomes South (WPD) which is not quite the same information

ah good spot, not I think it lost a word there somewhere. Let me fix that

peterdudfield avatar May 14 '24 11:05 peterdudfield