Feat/287 delta view

[braddf]

Pull Request

Description

Feature branch for Delta View (MVP)

Fixes #287

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [ ] Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

• [ ] Yes

Checklist:

• [ ] My code follows OCF's coding style guidelines
• [ ] I have performed a self-review of my own code
• [ ] I have made corresponding changes to the documentation
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have checked my code and corrected any misspellings

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nowcasting-app	✅ Ready (Inspect)	Visit Preview	💬 5 unresolved ✅ 23 resolved	Feb 13, 2023 at 5:55PM (UTC)
nowcasting-website	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 13, 2023 at 5:55PM (UTC)

[rachel-labri-tipton]

hey @braddf, so this morning I pulled the remote branch feat/287-delta-view branch into my local branch and then pushed my commits from yesterday. while I still see my new code for the header locally, and even here on the branch, I don't see anything when I run the code. and the vercel preview also doesn't show delta view stuff. Is there some setting, like setting delta = true somewhere in the code? In the meantime, I've set up a separate branch for my delta work delta-view-rt-work.

[rachel-labri-tipton]

hey @braddf, so i think the only think that needed to be updated is that the onClick={() => setViewFunc(view) for the delta view was commented out. does that make sense?

apologies for the gigantic screenshot. :)

[braddf]

Ah gotcha, good spot @rachel-labri-tipton, sorry that must have snuck in when I merged staging back into the delta branch to keep up-to-date and mergeable! 😅

[rachel-labri-tipton]

hey @braddf, I felt like this was more of a github comment than Slack message. I just wanted to give an update on what I've worked on on Tuesday.

So, I pushed my code for the gsp table and feel like hover issues have been sorted. I did a couple other small things that resolved comments Elisabeth had made on the Vercel branch (ie. adding an external link icon to the Help and Feedback link in the profile dropdown menu).

I also added a button for log back in on the logged out page. This resolves issue #313 that Dan flagged a bit ago. Currently on the deployed branch you can't see the button because you Sign out doesn't work anymore, but this might have something to do with changing around the auth0 audience.

[rachel-labri-tipton]

hey @braddf, just reading through all this helpful feedback. i'm winding down for the day and will respond and get to work on changes tomorrow.

[braddf]

Cool no worries, sounds good! 😊

[rachel-labri-tipton]

hey @braddf, I just pushed my updated delta view code and won't push anything else today, so it's safe to merge the map if and when it's ready. 🙂

[rachel-labri-tipton]

Delta-View Final To-Do List

• [ ] @braddf : working on API call for 4h forecast
• [x] Rachel: Get bucket styles back to what they were before refactoring and update tailwind color
• [x] Tooltip on the chart has an unlabelled line at the top. Probably should fix.
• [x] Rachel: Add delta color guide bar to the map (check it matches handoff design)
• [x] Brad: Style the tooltip
• [ ] Resolve Vercel comments on delta view and/or move comments to staging
• [ ] Check that logout / login is working
• [ ] Monday or Tuesday merge to staging (if possible with API/data missing or sorted)

[rachel-labri-tipton]

hey @dantravers , @braddf and i are ready to merge what we have here on the delta branch to staging today. this will help me start the solar site branch with the code up to date. Brad will maybe do one or two more delta things, like updating the delta bucket range feature tomorrow here on this branch and then will merge that new work tomorrow into staging. does that sound good to you?