predict_pv_yield icon indicating copy to clipboard operation
predict_pv_yield copied to clipboard

Try 2d, 3d CNN before attention

Open JackKelly opened this issue 4 years ago • 6 comments
trafficstars

related: #35

3D cnn: sees two timesteps at once

JackKelly avatar Jul 26 '21 17:07 JackKelly

https://github.com/openclimatefix/predict_pv_yield/blob/issue/85-perciever-nwp/predict_pv_yield/models/perceiver/perceiver_conv3d_nwp_sat.py

This model does now

peterdudfield avatar Oct 12 '21 08:10 peterdudfield

Nice! How well does the new model perform?! :)

JackKelly avatar Oct 12 '21 11:10 JackKelly

I dont have a direct comparision to running it without the cnn.

results: https://github.com/openclimatefix/predict_pv_yield/blob/issue/85-perciever-nwp/experiments/2021-09/2021-09-28/experiments.txt

peterdudfield avatar Oct 12 '21 11:10 peterdudfield

Cool beans. No rush, but it might be nice to have a direct comparison, so we can get a feel for whether it's useful to place a CNN before the attention. What do you think?

JackKelly avatar Oct 12 '21 11:10 JackKelly

yea, I think it would be a useful to do. Could also see if 01, ... N layers of CNN are useful?

peterdudfield avatar Oct 12 '21 11:10 peterdudfield

sounds great!

JackKelly avatar Oct 12 '21 12:10 JackKelly