graph_weather icon indicating copy to clipboard operation
graph_weather copied to clipboard
verified publisher icon openclimatefix

Fix NormalizedMSELoss and tests

Open jacobbieker opened this issue 3 years ago • 1 comments

Describe the bug No current tests for just NormalizedMSELoss, and a test fails because loss got deleted I guess

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here.

jacobbieker avatar Jul 04 '22 14:07 jacobbieker

Also NormalizedMSELoss currently doesn't take out the mean of the change like in the paper, it just ignores the variances as that was giving NaNs with the current implementation.

jacobbieker avatar Jul 19 '22 10:07 jacobbieker