graph_weather icon indicating copy to clipboard operation
graph_weather copied to clipboard

Add support for evaluating on ExtremeWeatherBench

Open jacobbieker opened this issue 10 months ago • 8 comments

We want to know how well the models work on extreme events, as well as averages. https://github.com/brightbandtech/ExtremeWeatherBench is a new benchmark for it that would be helpful.

jacobbieker avatar Jan 31 '25 09:01 jacobbieker

@jacobbieker, would I be able to pick up this issue?

sam2206hay avatar Feb 19 '25 16:02 sam2206hay

Yeah, sure!

jacobbieker avatar Feb 19 '25 16:02 jacobbieker

Ok thanks. Just for clarification, is this just a case of creating a new Dataloader that can load in the data in the EWB data format, and then making sure the model can generate predictions in the correct format?

sam2206hay avatar Feb 19 '25 16:02 sam2206hay

Yes, essentially, so then we can easily compare models across EWB.

jacobbieker avatar Feb 20 '25 20:02 jacobbieker

Ok thanks. Also, would you be able to assign me to the issue so I can create a branch and start working on this please?

sam2206hay avatar Feb 21 '25 13:02 sam2206hay

@jacobbieker, would you be able to give me push access as well please?

sam2206hay avatar Feb 21 '25 14:02 sam2206hay

You should be able to fork this repo, make the changes, and then open a PR back with the updates. That would be the preferred way for this.

jacobbieker avatar Feb 21 '25 14:02 jacobbieker

Right ok, thanks

sam2206hay avatar Feb 21 '25 14:02 sam2206hay

@jacobbieker, apologies for the delay, I have only recently managed to start working on this. One thing I have noticed is that when I run the example ExtremeWeatherBench script from the README I get an error no matter which example forecast I use. Do you know for sure that the ExtremeWeatherBench evaluation code works properly? I have also had some trouble working out how to load the data in the correct format as there isn't much documentation available and this is also my first time dealing with numerical weather prediction data.

sam2206hay avatar Mar 18 '25 11:03 sam2206hay

If this issue is still not resolved, I would like to help work on it

SkaarFacee avatar Jun 03 '25 00:06 SkaarFacee

@sam2206hay Sorry for the delay, I missed this. I'm not entirely sure the evaluation code works properly, but I think it does.

@SkaarFacee this hasn't been finished yet, so feel free to work on it if you want!

jacobbieker avatar Jun 03 '25 05:06 jacobbieker

@jacobbieker Just to make sure, did @sam2206hay start this and not finish it ? If the work is half way done can I continue from there or would you suggest to start from the beginning ?

SkaarFacee avatar Jun 03 '25 05:06 SkaarFacee

Hey, I'm not sure the status of what @sam2206hay has done. I would probably suggest start from the beginning.

jacobbieker avatar Jun 12 '25 14:06 jacobbieker

@jacobbieker I would love to contribute to this if it is still open!

Wendoom-dev avatar Jun 20 '25 08:06 Wendoom-dev

I think @SkaarFacee is working on this, but if not, go right ahead! I'd probably say though, if you are thinking of this one and #102, I would start on #102 first, since @SkaarFacee might be working on this one

jacobbieker avatar Jun 20 '25 08:06 jacobbieker

@jacobbieker understood I would focus on #102 and/or other issues for now!

Wendoom-dev avatar Jun 20 '25 08:06 Wendoom-dev

@jacobbieker @Wendoom-dev Unfortunately I haven't started work on this. I am caught up with another project. If you have the time you may proceed with this

SkaarFacee avatar Jun 20 '25 10:06 SkaarFacee

@jacobbieker,

I’m interested in contributing and wanted your advice — would you suggest I start with the ExtremeWeatherBench issue (#133) or continue focusing on the Anemoi Datasets issue (#102), which I’ve already committed to?

Thanks!

Wendoom-dev avatar Jun 20 '25 12:06 Wendoom-dev

I would say continue with #102 as I think it will be easier

jacobbieker avatar Jun 20 '25 14:06 jacobbieker

@jacobbieker understood I will get started working on #102, thanks for your patience and support!

Wendoom-dev avatar Jun 20 '25 14:06 Wendoom-dev

@jacobbieker I finished #102 should I start work on this or can you suggest any other beginner friendly issue I can contribute to?

Wendoom-dev avatar Jun 27 '25 12:06 Wendoom-dev

This one would be great to do!

jacobbieker avatar Jun 27 '25 23:06 jacobbieker

Thanks @jacobbieker I would be happy to take this up! Just for my understanding, I need to add support for a system which essentially runs extreme tests on our models? Also are there any previous PRs on this issue that I should refer to or start from scratch?

Wendoom-dev avatar Jun 28 '25 05:06 Wendoom-dev

If you look at the ExtremeWeatherBench repo, the issue is to get it so we can run the models in this repo on ExtremeWeatherBench. It would be starting from scratch

jacobbieker avatar Jun 28 '25 06:06 jacobbieker

Thanks for the clarification, I will start working on it!

Wendoom-dev avatar Jun 29 '25 17:06 Wendoom-dev

@jacobbieker, can you please assign me this issue?

shyama7004 avatar Aug 06 '25 09:08 shyama7004

Hlo @jacobbieker, I'm facing the same issue described here: https://github.com/brightbandtech/ExtremeWeatherBench/issues/106 I've encountered this issue on both Windows and Mac M1. I followed the README instructions, but the evaluation still fails. Any suggestions would be helpful.

shyama7004 avatar Aug 07 '25 08:08 shyama7004

Hmm, okay, might just need to wait for their response, I'd expect that they would get back to you pretty quick on it, but I'm not sure how to fix that issue unfortunately.

jacobbieker avatar Aug 07 '25 08:08 jacobbieker

Hmm, okay, might just need to wait for their response, I'd expect that they would get back to you pretty quick on it, but I'm not sure how to fix that issue unfortunately.

Ok, I have some solns in mind to fix the issue, but I am just waiting for their response.

shyama7004 avatar Aug 07 '25 08:08 shyama7004

Thanks for the catch. If you can hold off for a little bit there is an incoming refactor and that should address both issues alongside QoL improvements!

@jacobbieker, I think I have to wait as they are working on it. Issue Link: #106

shyama7004 avatar Aug 10 '25 15:08 shyama7004