openclimatefix
changed config in two files
Helps: https://github.com/openclimatefix/graph_weather/issues/126 What has changed?
- added dacite to requirements.txt
- added type checking using dacite for configuration in two places
@jacobbieker these are the two instances I found that needed this change, please let me know where else I need to do it.
Hi, this is a great start! We also want to have the dacite configurations used for the general torch modules, such as in https://github.com/openclimatefix/graph_weather/blob/15466e28fe827a75b849afd0a48803308d06acc4/graph_weather/models/forecast.py#L11 and the other PyTorch modules that have configurations.
Alright, thank you! will find and do the rest :) However, I don't understand why ruff is failing(for files I didn't commit). Am I missing something?
Alright, thank you! will find and do the rest :) However, I don't understand why ruff is failing(for files I didn't commit). Am I missing something?
Yeah, the pre-commit is broken right now on this repo. I wouldn't worry about it. I'll fix it at some point, for now its fine if its failing.