vmclarity icon indicating copy to clipboard operation
vmclarity copied to clipboard

AssetScan reconciler skips independent AssetScans because they have no Scan ID

Open Tehsmash opened this issue 1 year ago • 2 comments

Description

AssetScans were updated so that they could be used independently without being part of a batch of AssetScans managed by a Scan. In this case AssetScans will not have a Scan ID associated with them. A part of the AssetScan controller was missed during this change which results in AssetScans with no Scan ID getting skipped in the watching logic: https://github.com/openclarity/vmclarity/blob/main/pkg/orchestrator/assetscanwatcher/watcher.go#L114

Expected Behavior

AssetScans without a Scan ID should reconcile correctly.

Actual Behavior

They get skipped by the watcher.

Affected Version

v0.5.0

Steps to Reproduce

Create an AssetScan for an Asset without being part of a Scan. Observe the warnings in the logs.

Checklist

  • [X] I have read the contributing guidelines
  • [X] I have verified this does not duplicate an existing issue

Tehsmash avatar Aug 30 '23 07:08 Tehsmash