apiclarity icon indicating copy to clipboard operation
apiclarity copied to clipboard

Published 20 hours ago • verified publisher icon openclarity

feat: Enable multi-arch builds

Open kaechele opened this issue 2 years ago • 8 comments

AMD64, ARM64 and ARMv7 for now. The Tyk plugin depends on the tykio/tyk-plugin-compiler image which does not support any other architecture than AMD64 for now. See https://github.com/TykTechnologies/tyk-build-env/issues/4

Signed-off-by: Felix Kaechele [email protected]

kaechele avatar Feb 23 '22 17:02 kaechele

This can wait for now. Istio doesn't support ARM64 either, I figured out :P

kaechele avatar Feb 24 '22 02:02 kaechele

This can wait for now. Istio doesn't support ARM64 either, I figured out :P

bummer :( maybe we can try the Tap plugin instead of Istio in this case

akpsgit avatar Feb 24 '22 15:02 akpsgit

Upstream istio issue for multi-arch support: https://github.com/istio/istio/issues/26652

kaechele avatar Jun 01 '22 16:06 kaechele

@kaechele Istio now supports multi-arch builds (they work delightfully on my little RPi cluster 😅). Any chance that pushes the merge of this PR forward?

the-wondersmith avatar Nov 24 '22 16:11 the-wondersmith

I'd be happy to take another look at this, yes.

kaechele avatar Nov 24 '22 17:11 kaechele

@kaechele Just checking on this again. FWIW, I've built multi-arch images for API Clarity and deployed them to my local RPi cluster with the latest multi-arch istio images and it all works like a charm.

the-wondersmith avatar May 10 '23 14:05 the-wondersmith

Can we put a conditional in place to skip Tyk plugin build for non-amd64 architectures and list in the caveats that Tyk support is only available on amd64 platforms?

eti-tme-tim avatar May 18 '23 14:05 eti-tme-tim

The skipping should be in place already: For the GitHub actions:

  • https://github.com/openclarity/apiclarity/pull/86/files#diff-3f5366f6d6df3ec1179e5efadc6f350bfa88eebf4e2da589b4d94ccb85ae5e94R82
  • https://github.com/openclarity/apiclarity/pull/86/files#diff-e426ed45842837026e10e66af23d9c7077e89eacbe6958ce7cb991130ad05adaR147

And when building through the Makefile: https://github.com/openclarity/apiclarity/pull/86/files#diff-7eba0837a02c2deea05123583489cc7941f60b687718194ad0b30077c3181c62R22

Also, not sure why the build is failing in CI. Works fine locally.

kaechele avatar May 18 '23 20:05 kaechele