OpenCATS icon indicating copy to clipboard operation
OpenCATS copied to clipboard

Published 20 hours ago • verified publisher icon opencats

Retry installation link is not working

Open mlespiau opened this issue 8 years ago • 10 comments

When OpenCATS is already installed, the retry installation link is not working:

image

Also, once OpenCATS is installed, this page should require administrator privileges.

mlespiau avatar Dec 20 '16 18:12 mlespiau

If it's already installed on the system, it places the INSTALL_BLOCK in there which prevents you from going through the installation again. If you want to reinstall, the INSTALL_BLOCK, in the main Opencats directory needs to be deleted. So, unless I'm missing something, this is working as intended. However, the current version files have an Install block in the directory, which needs to be removed. I created an issue tonight for that.

cptr13 avatar Dec 24 '16 05:12 cptr13

regarding privileges, tests are written but failed due to wrong permission checked as reported, so were commented out (https://github.com/opencats/OpenCATS/commit/e5d70d242055753d7046bb4394f0516a40293772).

In tests, we use docker with INSTALL_BLOCK created, because database contains data after start. No tests for install process are written, requires different test environment.

But INSTALL_BLOCK in production is created during installation, there is no such file in repository nor in docker.

skrchnavy avatar Dec 24 '16 08:12 skrchnavy

ok, I hear you, but there's on here https://github.com/opencats/OpenCATS/releases/download/0.9.3-3/opencats-0.9.3-3-full.tar.gz Which is what I've been downloading and using the last couple of days.

cptr13 avatar Dec 24 '16 13:12 cptr13

Also in the full.zip file.

cptr13 avatar Dec 24 '16 13:12 cptr13

The one's labelled "source code" don't have it. What's the purpose of the first two files? All four should be named better to reflect the purpose.

cptr13 avatar Dec 24 '16 13:12 cptr13

OK, understood. Reason is that these files are bundled during travis build and after all tests and from testing environment.

skrchnavy avatar Dec 24 '16 14:12 skrchnavy

ok, can we label them as such? There are four files to choose from to download. It's hard to discern which are the ones to work from. Can we put -Test, or something on the end of those to differentiate from the release versions?

cptr13 avatar Dec 24 '16 15:12 cptr13

The link has been changed on this so as far as I know, there shouldn't be any more issues. Can we close this?

cptr13 avatar Jan 15 '17 13:01 cptr13

Retry installation shall ask for removal of install_block. This was not changed. this is where is the check: https://github.com/opencats/OpenCATS/blob/00166b4c3c83d0dcc9b7627411b144cb0d77758c/modules/install/ajax/ui.php#L46

skrchnavy avatar Jan 15 '17 14:01 skrchnavy

Ahh, ok, that's a great idea!

cptr13 avatar Jan 15 '17 15:01 cptr13