opencast-editor icon indicating copy to clipboard operation
opencast-editor copied to clipboard

Dynamic skip threshold

Open lkiesow opened this issue 9 months ago • 1 comments

The hard-coded threshold of 3s for skipping to the previous segment instead of skipping to the start of the segment can be too long for short videos, where visually, you are far away from the actual cut mark.

Screenshot from 2024-05-06 19-03-42

This patch fixes the problem by making this a dynamic threshold based on the video duration with a minimum of 0.5s (guarding against a non-set video duration) and a maximum of 3s.

lkiesow avatar May 06 '24 17:05 lkiesow

This pull request is deployed at test.editor.opencast.org/1329/2024-05-06_17-38-41/ . It might take a few minutes for it to become available.

github-actions[bot] avatar May 06 '24 17:05 github-actions[bot]

Thanks for the fix! It looks good to me.

Note: The maximum threshold of 3 seconds is reached with a video duration of 5 minutes. Otherwise it will be shorter.

dennis531 avatar May 07 '24 07:05 dennis531

Thanks for the review. Merging this so I can prep the new release…

lkiesow avatar May 07 '24 10:05 lkiesow