opencast-editor
opencast-editor copied to clipboard
opencast
Subtitle editor: Allow to change end time of segment in timeline by drag and drop
In the subtitle editor timeline, it was only possible to change the start time of a segment by drag and drop. This change makes it possible to change the end time in the same way.
Resolves #1314
Hi @snoesberger Thank you for contributing to the Opencast Editor. We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message! Please let us know if you have any questions regarding the CLA.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @snoesberger Thank you for contributing to the Opencast Editor. We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message! Please let us know if you have any questions regarding the CLA.
It's a bit unfortunate that I can't test this just because the ICLA hasn't been processed yet. :sweat_smile:
I filled in the ICLA a week ago, but haven't received a confirmation yet.
Apereo got the ICLA. Please just ignore the test for now. It can take a while before that is officially documented. If anyone asks, please point them to this comment.
It's a bit unfortunate that I can't test this just because the ICLA hasn't been processed yet. 😅
Maybe to avoid future confusion about this, a few words about the test deployment, which absence I think you are complaining about. First, you can always just clone this and run npm start locally.
Second, I think here is a misconception that the failing ICLA test has something to do with the missing test deployment. Since that is deploying code, for security reasons, it's only doing that for known developers. To be more precise, it's limited to people in the team Developers of the Opencast organization here on GitHub:
https://github.com/opencast/opencast-editor/blob/fbae57c560a48ba997aa9cf10de3540e3f1d9973/.github/workflows/update-test.yml#L11-L12
@gregorydlogan or I can easily add more people to that group. If you want access or want someone else to have access, just let us know. @snoesberger, I've invited you to that team.
Second, I think here is a misconception that the failing ICLA test has something to do with the missing test deployment. Since that is deploying code, for security reasons, it's only doing that for known developers. To be more precise, it's limited to people in the team
Developersof the Opencast organization here on GitHub:
Ah, thx, I did not know this! Makes sense.
Tried this and found a bug. It seems like you get two input fields for subtitles whenever you start a new subtitle: opencast-editor-subtitle-two-input-fields.mp4
Thanks for testing, Lars. This is strange, I can reproduce the behaviour but only when I start the editor in development mode. If I build the editor and start the new build, only one input field is added. And I have the same behaviour when I do the same for the main branch, so it looks like this problem hasn't been added by the changes in this PR.
I'd love to see this PR merged. Or is there still something preventing it from being merged?
