opencast-editor icon indicating copy to clipboard operation
opencast-editor copied to clipboard

Fix alignment of workflow title

Open lkiesow opened this issue 1 year ago • 19 comments

If the workflow selection is shown because there are more than one workflow tagged editor in Opencast, the workflow title is slightly misaligned with the radio button. A few pixels of top padding should fix that:

Screenshot from 2023-10-02 21-24-32

lkiesow avatar Oct 02 '23 19:10 lkiesow

Hello, I would like to work on this issue. Can you assign this to me?

joshijoe05 avatar Oct 02 '23 19:10 joshijoe05

Sure. Thanks for taking this up.

Please unassign yourself and/or let us know if you don't want to work on this after all, so that someone else can take this up.

lkiesow avatar Oct 02 '23 21:10 lkiesow

Can you guide me which file it actually was?

joshijoe05 avatar Oct 03 '23 03:10 joshijoe05

Should be in src/main/WorkflowSelection.tsx

Arnei avatar Oct 04 '23 07:10 Arnei

Hi, Can i work on this issue. Is it still open?

Prashant04627 avatar Oct 14 '23 20:10 Prashant04627

Hey, yes it is still open. I assigned you.

Please unassign yourself and/or let us know if you don't want to work on this after all, so that someone else can take this up.

Arnei avatar Oct 16 '23 06:10 Arnei

Lets do this!

Prashant04627 avatar Oct 17 '23 10:10 Prashant04627

REACT_APP_GIT_SHA' is not recognized as an internal or external command, operable program or batch file. It says this when i started to run the project locally. Also i can't find the solution, Arnei can you help me out with this.

Prashant04627 avatar Oct 17 '23 11:10 Prashant04627

That is strange o.O, haven't seen that one before.

Just to make sure the basics are covered: Command-line git and npm are set up on your device, and you ran npm ci (or somesuch) before running npm start?

Arnei avatar Oct 17 '23 12:10 Arnei

No nothing works. I think i should be unassigned. Thank you

Prashant04627 avatar Oct 18 '23 07:10 Prashant04627

That is unfortunate, thank you very much for trying though.

Arnei avatar Oct 18 '23 09:10 Arnei

HI @Arnei , can I work on this ?

Dhananjay-12 avatar Nov 21 '23 16:11 Dhananjay-12

You absolutely can @Dhananjay-12

Arnei avatar Nov 21 '23 16:11 Arnei

Hi, @Arnei how to reach that workflow option. I only see these three for now. Screenshot from 2023-11-21 23-37-59

Dhananjay-12 avatar Nov 21 '23 18:11 Dhananjay-12

Hi @Dhananjay-12,

On the screen you posted, click on the "Start processing" button to get to the workflow selection. However, there will only be some text, because per default there is only one workflow. To get the radio menu to show up, you'll need at least to workflows. Now you could set up your own Opencast and configure it with multiple workflows for the editor, but it is probably way easier to temporarily hack some workflows into the frontend somehow. Btw the file you'll likely be looking at is src/main/WorkflowSelection.tsx

Arnei avatar Nov 22 '23 07:11 Arnei

Hi @Arnei, can you give me a hint on how to increase workflows , I could just come up with this dumb idea and it didn't work Screenshot from 2023-11-22 23-30-03

Dhananjay-12 avatar Nov 22 '23 18:11 Dhananjay-12

In src/main/WorkflowSelection.tsx:

  // Initialite redux states
  let workflows = useSelector(selectWorkflows)
  // Need to make copy to handle undefined displayOrder values
  workflows = [...workflows].sort((a, b) => {
    return (b.displayOrder - a.displayOrder)
  })
  workflows.push({id: "1324", name: "name", description: "description", displayOrder: 42})

Arnei avatar Nov 23 '23 07:11 Arnei

Hi @Arnei , is this good ? Screenshot from 2023-11-23 15-27-08

Dhananjay-12 avatar Nov 23 '23 09:11 Dhananjay-12

Oops @Arnei , I think prettier made too many changes with the formatting, creating another PR

Dhananjay-12 avatar Nov 23 '23 10:11 Dhananjay-12