opencast-editor icon indicating copy to clipboard operation
opencast-editor copied to clipboard

Coherent use of canvases (if that's the plural for canvas)

Open oas777 opened this issue 1 year ago • 7 comments

Complementary and preparatory with my suggestion for coherent "elements" I suggest to coherently use the white canvas for video(s):

https://test.editor.opencast.org/1079/2023-07-17_14-50-34/ has a white canvas for each video in "Spuren" and "Vorschaubild", but not in "Schneiden".

oas777 avatar Jul 17 '23 17:07 oas777

Actually, by now I think I overdid it with the boxing of elements in the "Thumbnail/Vorschaubild" view. So instead of coherently using white canvases everywhere, how about coherently not using them?

Bildschirmfoto vom 2023-07-18 09-10-38

And I'm differentiating between Video Player elements (in e.g. "Schneiden/Cutting") and preview image elements (in e.g. "Spuren/Tracks"). I still think it is fine and possibly beneficial to treat them differently.

Arnei avatar Jul 18 '23 07:07 Arnei

In line with https://github.com/opencast/opencast-editor/issues/1107#issuecomment-1641059970, I would argue in favor of separating the two videos and give them a white canvas each to match the previews above. Once they are aligned, you might try a "non-canvas" design so we can decide how to move forward.

oas777 avatar Jul 18 '23 22:07 oas777

I hope you don't actually mean what you wrote down. The dark mode in your example, @oas777, has no white canvas as far as I can tell. Adding one would probably look pretty bad.

Screenshot from 2023-08-10 12-37-58

So, I think/hope you mean a neutral canvas based on the color mode?

lkiesow avatar Aug 10 '23 10:08 lkiesow

Yes, I was obviously commenting in the context of the custom mode, where white makes sense to me. What's your suggestion for the dark mode?

oas777 avatar Aug 11 '23 09:08 oas777

Copying over some screenshots Olaf took of the current state. He would like titles in every canvas:

grafik vs. grafik vs. grafik

Arnei avatar Sep 13 '23 13:09 Arnei

While I can see how having a track title (i.e. the track main flavor) in every canvas would be overall more consistent, I'm personally not in favour of it. I don't think we should use space to display information that is not relevant to the task at hand. For example, when cutting it is not important to me what the tracks main flavors are, unlike when selecting a track where the preview image may not be sufficient to differentiate between tracks.

But that's just my opinion, I would like to hear others opinions on this.

Arnei avatar Sep 13 '23 13:09 Arnei

@lkiesow?

oas777 avatar Sep 14 '23 14:09 oas777