annotation-tool icon indicating copy to clipboard operation
annotation-tool copied to clipboard

Editing categories: Window after clicking on the arrow gets hidden when there are categories with only few labels

Open dagraf opened this issue 3 years ago • 6 comments

See screenshot

Screenshot (33)

dagraf avatar Nov 23 '21 12:11 dagraf

Note: This is not an urgent bug. Mainly because the user can manually enlarge the "Create new annotations" window. But anyhow it should be fixed some time...

dagraf avatar Dec 09 '21 09:12 dagraf

The sad truth is also that this isn't an easy thing to fix. You would think that it is, but ti's complicated by the convoluted structure of the "structured annotation creation component," and even the naive and hacky ways of working around that are squashed by us using an ancient version of the "UI framework" (talking about Bootstrap) we are using. :disappointed:

JulianKniephoff avatar Dec 13 '21 12:12 JulianKniephoff

Truly sad but not that important. Here some ideas for workaround solutions to gain more space for the box containing the categories with its labels: a) The default hight for free text annotations could be made a bit smaller. b) In the layout preset "Standard" the window "Create new annotations" could be made higher than the window "Annotation list". For example: "Create new annotations" = 3/5 of max. hight; "Annotation list" = 2/5 of max. hight

What do you think of these possible workarounds?

dagraf avatar Jan 03 '22 10:01 dagraf

Maybe a CSS cheat can help with position:fixed; or other more modern CSS approaches (?):

CSS cheat

Challenges would then be:

  • Does it work in all browsers?
  • Position needs to be calculated from the origin element (hardcoded for screenshot)
  • On resizing the window, it should be either repositioned -or- closed

ChristianOellers avatar Oct 10 '22 14:10 ChristianOellers

I don't want to sound mean or anything, but I would really hesitate to add a lot of complexity to fix this. If there is a simple CSS one-liner, sure, but I don't think there is. Adding JavaScript code to dynamically reposition this window, etc. when this functionality already exists in newer versions of Bootstrap seems crazy to me. We should update our dependencies, not haphazardly duplicate their functionality. :thinking: It's exactly decisions like this that brought about the current state of the code base; choosing quick fixes over long term maintainability.

As for the workarounds suggested by David (sorry, somehow I'm only seeing this now): I have nothing against that. It's easy, and it's also not like I put a lot of thought into that Standard layout. x)

JulianKniephoff avatar Oct 10 '22 15:10 JulianKniephoff

Bug still exists in merged version.

dagraf avatar Feb 09 '23 16:02 dagraf