openauto icon indicating copy to clipboard operation
openauto copied to clipboard

Cranskhaft with aasdk next

Open dicetrash opened this issue 1 year ago • 4 comments

Make opencardev/openauto work with opencardev/aasdk newdev

dicetrash avatar Jun 16 '23 04:06 dicetrash

Does this pr compile for you? I've tried to compile it, but am getting the following error.


/home/pi/workspace/buildsystem/openauto/src/btservice/AndroidBluetoothServer.cpp:27:10: fatal error: aasdk_proto/WifiInfoRequestMessage.pb.h: No such file or directory
   27 | #include <aasdk_proto/WifiInfoRequestMessage.pb.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/btservice.dir/build.make:121: CMakeFiles/btservice.dir/src/btservice/AndroidBluetoothServer.cpp.o] Error 1

matt2005 avatar Jun 20 '23 20:06 matt2005

My libaasdk.so was compiled off aasdk with newdev branch and then I added WifiInfoRequestMessage.proto back from master so yes it compiled .., I can add an MR https://github.com/opencardev/aasdk/pull/20 to add the three deleted proto files back into aasdk, not familiar enough with the project to know why they where deleted. More info from aasdk maintainers would be good to see where they want to go with this. https://github.com/opencardev/aasdk/compare/newdev...opencardev:aasdk:development is the stuff in develop branch that never made it to newdev

dicetrash avatar Jun 23 '23 21:06 dicetrash

I'll verify it builds and test it over the weekend

matt2005 avatar Jun 23 '23 23:06 matt2005

I checked-out this pull request, and I needed to make the following edit to be able to compile:

diff --git a/src/autoapp/Projection/OMXVideoOutput.cpp b/src/autoapp/Projection/OMXVideoOutput.cpp
index f8f3808..6a46380 100644
--- a/src/autoapp/Projection/OMXVideoOutput.cpp
+++ b/src/autoapp/Projection/OMXVideoOutput.cpp
@@ -23,7 +23,7 @@ extern "C"
 #include <bcm_host.h>
 }
 
-#include <f1x/aasdk/Common/Data.hpp>
+#include <aasdk/Common/Data.hpp>
 #include <f1x/openauto/autoapp/Projection/OMXVideoOutput.hpp>
 #include <f1x/openauto/Common/Log.hpp>
 

Fabio3rs avatar Oct 01 '23 21:10 Fabio3rs