OpenCAD-php icon indicating copy to clipboard operation
OpenCAD-php copied to clipboard

NCIC API Created + Bug Fixes

Open kevingorman1000 opened this issue 2 years ago • 5 comments

Fully created the NCIC API. Documentation has been started and is included but subject to change. Users API will be to follow. Updated, better documentation will be to follow.

kevingorman1000 avatar Jul 12 '22 20:07 kevingorman1000

If you are in need of some help writing documentation, let me know.

From: kevingorman1000 @.> Sent: Tuesday, July 12, 2022 4:51 PM To: opencad-app/OpenCAD-php @.> Cc: Subscribed @.***> Subject: [opencad-app/OpenCAD-php] NCIC API Created (PR #429)

Fully created the NCIC API. Documentation has been started and is included but subject to change. Users API will be to follow. Updated, better documentation will be to follow.


You can view, comment on, or merge this pull request online at:

https://github.com/opencad-app/OpenCAD-php/pull/429

Commit Summary

File Changes

(30 fileshttps://github.com/opencad-app/OpenCAD-php/pull/429/files)

Patch Links:

  • https://github.com/opencad-app/OpenCAD-php/pull/429.patch
  • https://github.com/opencad-app/OpenCAD-php/pull/429.diff

— Reply to this email directly, view it on GitHubhttps://github.com/opencad-app/OpenCAD-php/pull/429, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADS4MAEGYLZRP6ELSNSRFQLVTXLEDANCNFSM53MKK3YA. You are receiving this because you are subscribed to this thread.Message ID: @.@.>>

Cambridgeport90 avatar Jul 12 '22 20:07 Cambridgeport90

ryGuy has agreed to work on the auto generated one I have. I'd like to work with swagger at some point but having some issues getting it working properly. Something for the future for sure.

kevingorman1000 avatar Jul 12 '22 20:07 kevingorman1000

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 27 '22 11:07 sonarqubecloud[bot]

@kevingorman1000 is this ready to be merged?

ItsAGeekThing avatar Jul 29 '22 21:07 ItsAGeekThing

Currently, yeah, i still have to finish the other parts of the api but unsure when I'll get around to it. Worth commiting it now as it resolves some DB error breaking install

kevingorman1000 avatar Jul 30 '22 08:07 kevingorman1000