OpenBullet2 icon indicating copy to clipboard operation
OpenBullet2 copied to clipboard

Switched to AsyncKeyedLock

Open MarkCiliaVincenti opened this issue 1 year ago • 13 comments

This PR will reduce memory allocations and memory usage.

MarkCiliaVincenti avatar Mar 05 '23 09:03 MarkCiliaVincenti

@openbullet :)

MarkCiliaVincenti avatar Mar 23 '23 09:03 MarkCiliaVincenti

Hey sorry I didn't have time to look into this yet, will do soon ^^'

openbullet avatar Mar 25 '23 23:03 openbullet

Hey sorry I didn't have time to look into this yet, will do soon ^^'

gentle reminder :)

MarkCiliaVincenti avatar Apr 06 '23 15:04 MarkCiliaVincenti

@openbullet asked me to try it. And i noticed that jobs don't start as they don't load proxies. - without proxies it seems to be ok. (tho i did no extensive test without being able to use proxies) (Tested on native)

meinname avatar Apr 29 '23 12:04 meinname

@openbullet asked me to try it. And i noticed that jobs don't start as they don't load proxies. - without proxies it seems to be ok. (tho i did no extensive test without being able to use proxies) (Tested on native)

Hi,

What would be the easiest way to reproduce this issue please so that I could maybe debug? Or would you kindly be able to debug and tell me where the issue lies please?

MarkCiliaVincenti avatar Apr 30 '23 06:04 MarkCiliaVincenti

@meinname

MarkCiliaVincenti avatar May 14 '23 07:05 MarkCiliaVincenti

Simply try to start a job with proxies. It wont start

meinname avatar May 14 '23 08:05 meinname

@meinname I'm going to need more info to replicate this issue please. Also can you try again please?

MarkCiliaVincenti avatar Dec 21 '23 09:12 MarkCiliaVincenti

@meinname please let me know. I've also updated to the latest version of the library with performance improvements.

MarkCiliaVincenti avatar Jan 23 '24 11:01 MarkCiliaVincenti

Still. When starting a Job with proxies off it seems to work. But as soon as i use proxies (tested from OB2 Proxy Manager and from File) a Job with a simple config only remains at Starting... (only did a quick test this time on native Client on Windows)

meinname avatar Jan 23 '24 13:01 meinname

Would you be so kind as to dumb it down into steps with screenshots to reproduce? And can you confirm that without the PR it does not give an issue?

MarkCiliaVincenti avatar Jan 23 '24 13:01 MarkCiliaVincenti

I don't know hot to dumb it down more - but i try

First i check out ob2 master to a new directory and publish it to a new directory. Then i start the native client and create a new config - basically anything you want. - i just used one as simple as that one:

BLOCK:RandomInteger
  => VAR @randomIntegerOutput
ENDBLOCK

BLOCK:Keycheck
  KEYCHAIN SUCCESS OR
    INTKEY @randomIntegerOutput GreaterThanOrEqualTo 9
  KEYCHAIN FAIL OR
    INTKEY @randomIntegerOutput LessThan 9
ENDBLOCK

and add a few simple proxies on ob2 proxy tab to a new group. As they aren't used with this config, i just add some like 127.0.0.1:9000 127.0.0.1:9001 .... or real ones or whatever.

I create a new multirun job and select the config. - set bots to 10 - proxy mode to on - wordlist either use one via file or just use infinite And then go to the job and start it. It works. - job runs and you get successes and fails

then do the same but with the PR merged And then you can see that after pressing start ob2 does nothing. Beside job status is and stays on "Starting..." Edit: oh, and if i do the same and switch proxy mode to off it works

meinname avatar Jan 23 '24 13:01 meinname

That looks very helpful actually @meinname, thanks I'll look at it probably over the weekend.

MarkCiliaVincenti avatar Jan 23 '24 14:01 MarkCiliaVincenti