phosphor-webui icon indicating copy to clipboard operation
phosphor-webui copied to clipboard

Network settings must not list per-interface gateways

Open AlexanderAmelkin opened this issue 6 years ago • 5 comments

As discussed in the following issues in other parts of openbmc project, on non-router systems there is no such concept as per-interface gateway:

https://github.com/openbmc/openbmc/issues/2671 https://github.com/openbmc/phosphor-networkd/issues/22

Hence, there is no need to have the associated fields in web-ui. They only confuse the users:

webui-network-gateways

AlexanderAmelkin avatar Jun 21 '18 15:06 AlexanderAmelkin

Additionally, the ids of inputs for "Gateway" and for "Netmask prefix length" are confused in HTML. The "Gateway" input has id="net-config__subnet" whereas the "Netmask prefix..." input has id="net-config__default-gateway".

AlexanderAmelkin avatar Jun 26 '18 11:06 AlexanderAmelkin

related issue https://github.com/openbmc/phosphor-webui/issues/62

susantjasinski avatar Feb 26 '19 17:02 susantjasinski

@AlexanderAmelkin The design team has updated the UI proposal, please review at https://ibm.invisionapp.com/share/RQNYHJ0VBDY#/319002386_V2_Networking_Mutliple_VLAN . The corresponding issue is the one tagged above by Susan

jandraa avatar Feb 28 '19 19:02 jandraa

@jandraa, thank you for the update!

AlexanderAmelkin avatar Mar 04 '19 15:03 AlexanderAmelkin

This will be addressed with story #62.

derick-montague avatar Jul 24 '19 15:07 derick-montague