openbmc-test-automation icon indicating copy to clipboard operation
openbmc-test-automation copied to clipboard

A issue about "Get Time Difference" in test_ipmi_sel_time.robot

Open Julia-Delta opened this issue 1 year ago • 3 comments

When I test ipmi sel time items, I got value -1 about the difference between BMC time and SEL time. I found that the parameter order seems wrong. In line 134, line 285 and line 337, the diff time was get_sel_time minus bmc_time. But bmc_time was the newest time, so the diff time maybe negative number. I think that the condition need to modify and change "${difference}= Get Time Difference ${get_sel_time} ${bmc_time}" to "${difference}= Get Time Difference ${bmc_time} ${get_sel_time}"

Julia-Delta avatar Jul 22 '24 02:07 Julia-Delta

@Ganesan149 @KothaiSrini or @Alagiridhilipank can u guys take a look and respond to this ?

gkeishin avatar Aug 21 '24 05:08 gkeishin

or @KManimozhi123

gkeishin avatar Aug 21 '24 05:08 gkeishin

@Julia-Delta @gkeishin

yes, this requires code change. In line 134, line 158, line 285 and line 337 these 4 lines the changes needs to be done.

Ganesan149 avatar Aug 23 '24 19:08 Ganesan149

As suggested the changes in 134, line 158, line 285 and line 337 are made in this commit https://gerrit.openbmc.org/c/openbmc/openbmc-test-automation/+/79095

SrideviRamesh avatar Mar 21 '25 17:03 SrideviRamesh