libmctp
libmctp copied to clipboard
openbmc
In mctp-demux-daemon.c line #885 ctx->pcap.binding.dumper is being used although it is uninitialized.
err.h was needed some time ago when astlpc.c just called warnx() and errx() directly. It uses a logging wrapper now so this isn't needed and since it's a BSD header...
Syntax errors in the astlpc case and linker issues in the demux daemon.
https://github.com/openbmc/libmctp/blob/ba6727e6d61d19720d4ca8756f465375adc82536/core.c#L610-L611 I appears that the value stored at the pointer and the value of the pointer itself are never altered so they should be labeled as const.
Opening issue to discuss libmctp security related topics. If MCTP packets are received with End of message (EOM) or start of message (SOM) not set, they get added to context...
I think we are leaving ourselves open to a race condition if we set the ODR first. Setting the ODR will trigger the OBF bit in the status register which...