bmcweb icon indicating copy to clipboard operation
bmcweb copied to clipboard

bmcweb: redfish: Modify update_schema script to support OEM schemas

Open devenrao opened this issue 6 years ago • 6 comments

There's a bug in the script that currently deletes this schema (because it's an OEM schema). Because it's the only one, and we don't update schemas very often, we just manually fix it until someone proposes a more permanent fix.

Refer to the code comments in this patch https://gerrit.openbmc-project.xyz/#/c/openbmc/bmcweb/+/17551/4/scripts/update_schemas.py

devenrao avatar Jan 24 '19 08:01 devenrao

FYI, this is just an issue when we update schemas. This does not have any functional impact on the BMC itself, unless this is forgotten during a schema update.

With that said, would love to see a fix for it.

edtanous avatar Feb 02 '19 18:02 edtanous

@feistjj Can you please reopen? This is still an issue and is referenced in the update_schemas.py

gtmills avatar Feb 06 '20 22:02 gtmills

Opening back up to change it to handle it with a glob or similar so we can stop patching the script

feistjj avatar Feb 07 '20 17:02 feistjj

This was fixed a while back; Closing.

edtanous avatar Jun 07 '21 16:06 edtanous

Still referenced here in the script: https://github.com/openbmc/bmcweb/blob/master/scripts/update_schemas.py#L206

gtmills avatar Jun 07 '21 18:06 gtmills

My recollection of this bug was that section of code used to not exist, and you formerly had to run the script, then add back the OEM schemas that got deleted before you checked stuff in. Clearly I was remembering an earlier issue. My bad, reopening.

edtanous avatar Jun 08 '21 00:06 edtanous

Script was fixed a while back, and now looks for "Oem" and "OpenBMC" namespaces for oem schemas.

While the solution we have is imperfect, it no longer requires manual intervention, so closing this bug.

edtanous avatar Mar 27 '23 17:03 edtanous