bmcweb icon indicating copy to clipboard operation
bmcweb copied to clipboard

OemSession implements "client id" which is already covered in standard

Open edtanous opened this issue 4 years ago • 4 comments

OemSession implements a new field, ClientId, which in practice is perfectly analogous to session id (the resource id itself). It's not clear why this extra unique ID was added, but it's unnecessary. Resources that need to reference the session can simply point to the session in question with a link, rather than needing an extra explicit ID.

edtanous avatar Feb 18 '21 03:02 edtanous

I think this "client id" needs to be read/write. Is that correct @ratagupt ?

https://redfishforum.com/thread/324/proposal-connected-redfish-client-info

gtmills avatar Mar 09 '21 02:03 gtmills

@sunharis Can you weigh in here?

gtmills avatar Oct 14 '21 15:10 gtmills

@edtanous @gtmills The Oem - ClientId is added to send an additional Id string from the client. This string is decided by the client and is an input to the BMC while creating the session. This can be a string holding the clients nick-name/serial number/machine-model number etc. Any other client connected can also see this ClientId and get to know "who" is the session owner.

The sessionId is something which BMC generates and the redfish client will not know/predict this value before-hand. And any other client connected will not be able to find "who" is the owner of that session.

We have the IP address stored at session object - but you can always create multiple sessions from a single IP address.

sunharis avatar Oct 19 '21 13:10 sunharis

Resolved by https://gerrit.openbmc.org/c/openbmc/bmcweb/+/56088

gtmills avatar Aug 30 '22 19:08 gtmills

Closing. This is now in the standard implementation.

edtanous avatar Mar 27 '23 18:03 edtanous