fcode-utils icon indicating copy to clipboard operation
fcode-utils copied to clipboard

Published 20 hours ago • verified publisher icon openbios

Add basic EFI romheaders support

Open zajdee opened this issue 7 years ago • 1 comments

This commit adds a very basic EFI romheaders support. It also prints a short comment on code type 0xff, which is being used by iPXE.

zajdee avatar Sep 02 '18 21:09 zajdee

Thanks for the patch! I've had a look at this and the preparatory cleanup work in patches 1-3 seems good to me.

From what I can see of patch 4 it also seems reasonable, however the formatting style e.g. braces around for() loops etc. doesn't seem to match that of the existing code. Can you repush with the formatting corrected?

Finally can I ask what you're using this for? I don't really have a way of testing EFI builds here so I'd be reliant on someone else to make sure that this patchset is working as expected.

mcayland avatar Sep 09 '18 14:09 mcayland