OpenBikeSensorFirmware icon indicating copy to clipboard operation
OpenBikeSensorFirmware copied to clipboard

Published 20 hours ago • verified publisher icon openbikesensor

Improve display in server mode

Open boldt opened this issue 3 years ago • 4 comments

Fixes #284

  • Show the press button info after APL data handled, not just when the button got pressed
  • Do not clear the display, when the HTTPSServer ist created. Thus, the APL info stays in the display until the loading bar shows up

boldt avatar Sep 03 '22 13:09 boldt

Thanks @boldt for this PR. Actually I did not want to add a delay here. The user might just want to upload the new track data and is not interested in technical details if the ALP update took place or not. I'm open for other opinions on this, what do you think?

amandel avatar Sep 06 '22 09:09 amandel

Thanks @boldt for this PR. Actually I did not want to add a delay here. The user might just want to upload the new track data and is not interested in technical details if the ALP update took place or not. I'm open for other opinions on this, what do you think?

New fix without delay pushed

boldt avatar Oct 08 '22 14:10 boldt

Please retry analysis of this Pull-Request directly on SonarCloud.

sonarqubecloud[bot] avatar Oct 08 '22 14:10 sonarqubecloud[bot]

Better now ;) - I like this additional information without delay!

amandel avatar Oct 09 '22 09:10 amandel

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 03 '22 18:12 sonarqubecloud[bot]