openbabel
openbabel copied to clipboard
Fetch current rapidjson codebase rather than last release
Version 1.1.0 of rapidjson is now 8 years old, and building Open Babel is currently broken on recent Linux systems as a result. Using the current code incorporates the many patches since 2016 such as this PR.
Thanks for opening this pull request! Please check out our contributing guidelines and please examine any build issues.
No, we're not going to grab master. For consistency and security, it's much better to grab a specific commit hash. That's immutable.
I'd rather see a new release of rapidjson, but in the meantime, I'd prefer something like 7c73dd7de7c4f14379b781418c6e947ad464c818
Fair enough, I swapped in the hash you suggested i.e. the most recent commit hash.
Congrats on merging your first pull request! 🎉 You're helping make Open Babel better for everyone!