openbabel icon indicating copy to clipboard operation
openbabel copied to clipboard

Fetch current rapidjson codebase rather than last release

Open matterhorn103 opened this issue 1 year ago • 3 comments

Version 1.1.0 of rapidjson is now 8 years old, and building Open Babel is currently broken on recent Linux systems as a result. Using the current code incorporates the many patches since 2016 such as this PR.

matterhorn103 avatar Sep 16 '24 07:09 matterhorn103

Thanks for opening this pull request! Please check out our contributing guidelines and please examine any build issues.

welcome[bot] avatar Sep 16 '24 07:09 welcome[bot]

No, we're not going to grab master. For consistency and security, it's much better to grab a specific commit hash. That's immutable.

I'd rather see a new release of rapidjson, but in the meantime, I'd prefer something like 7c73dd7de7c4f14379b781418c6e947ad464c818

ghutchis avatar Sep 16 '24 19:09 ghutchis

Fair enough, I swapped in the hash you suggested i.e. the most recent commit hash.

matterhorn103 avatar Sep 16 '24 21:09 matterhorn103

Congrats on merging your first pull request! 🎉 You're helping make Open Babel better for everyone!

welcome[bot] avatar Dec 07 '24 15:12 welcome[bot]