theyvoteforyou
theyvoteforyou copied to clipboard
When we don't have an image for a member, show something better than text “Photo of <name>”
This looks really sloppy:
This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you!
👍
What would the solution of this issue look like? Even after updating the members images there might be members without an image.
Example: Senator Greg Mirabella does not have an image.
See senator images and member images here.
Some good news, its only Senator Greg Mirabella that does not have a photo. All other members and senators do.
The idea would be to use some kind of generic gender neutral image if there isn't an existing photo. An example of the kind of thing would be https://thenounproject.com/icon/user-3692903
It would obviously need to be scaled down and made a lighter colour so it doesn't completely dominate any other image
This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you!
More like this?
Could have different coloured backgrounds as per senate (red) and house of reps (green) photos also. @mackaymackay @mlandauer if you think that's a good idea please assign and @ me and I'll go ahead and create them
@katska I think having green/red backgrounds could be helpful, as it would match what parliament already tends to do with their photos (using the red or green background for the senators or MPs respectively)
While looking at this, I just noticed that we don't seem to have people without photos showing up on the general policy pages at all anymore.
e.g. on his voting card, Stephen Bates is listed as voting consistently for net zero emissions, but he doesn't appear on the actual policy page
I've created a new issue for this, as it's actually a bit of a problem for the newer policies.
@mackaymackay That's no good! Thanks for spotting the problem!
I'm reopening this issue, as it seems to be related to https://github.com/openaustralia/theyvoteforyou/issues/1443 (as mentioned above)