theyvoteforyou icon indicating copy to clipboard operation
theyvoteforyou copied to clipboard

When we don't have an image for a member, show something better than text “Photo of <name>”

Open equivalentideas opened this issue 8 years ago • 4 comments

This looks really sloppy:

screen shot 2016-09-01 at 5 24 09 pm

equivalentideas avatar Sep 01 '16 07:09 equivalentideas

This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you!

stale[bot] avatar Oct 13 '21 03:10 stale[bot]

👍

mlandauer avatar Oct 20 '21 08:10 mlandauer

What would the solution of this issue look like? Even after updating the members images there might be members without an image.

Example: Senator Greg Mirabella does not have an image.

See senator images and member images here.

Some good news, its only Senator Greg Mirabella that does not have a photo. All other members and senators do.

MutazAshhab avatar Feb 08 '22 00:02 MutazAshhab

The idea would be to use some kind of generic gender neutral image if there isn't an existing photo. An example of the kind of thing would be https://thenounproject.com/icon/user-3692903 noun-user-3692903 It would obviously need to be scaled down and made a lighter colour so it doesn't completely dominate any other image

mlandauer avatar Feb 10 '22 05:02 mlandauer

This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you!

stale[bot] avatar Aug 16 '22 12:08 stale[bot]

More like this? Screen Shot 2022-08-17 at 10 42 00 am

Could have different coloured backgrounds as per senate (red) and house of reps (green) photos also. @mackaymackay @mlandauer if you think that's a good idea please assign and @ me and I'll go ahead and create them

katska avatar Aug 17 '22 00:08 katska

@katska I think having green/red backgrounds could be helpful, as it would match what parliament already tends to do with their photos (using the red or green background for the senators or MPs respectively)

While looking at this, I just noticed that we don't seem to have people without photos showing up on the general policy pages at all anymore.

e.g. on his voting card, Stephen Bates is listed as voting consistently for net zero emissions, but he doesn't appear on the actual policy page

image

I've created a new issue for this, as it's actually a bit of a problem for the newer policies.

mackaymackay avatar Aug 18 '22 22:08 mackaymackay

@mackaymackay That's no good! Thanks for spotting the problem!

katska avatar Aug 22 '22 01:08 katska

I'm reopening this issue, as it seems to be related to https://github.com/openaustralia/theyvoteforyou/issues/1443 (as mentioned above)

mackaymackay avatar Oct 21 '22 05:10 mackaymackay