morph icon indicating copy to clipboard operation
morph copied to clipboard

Make Docker network subnet configurable

Open henare opened this issue 9 years ago • 1 comments

And don't use a really common home network by default.

This took me ages to debug. After running a scraper with the latest code the scraper couldn't connect to the internet. I thought I'd stuffed something up until I realised my whole machine couldn't access the internet. In the end I discovered that morph had created a 192.168.0.0/16 network so all the traffic from my machine to my local network was being routed into the Docker network and therefore I couldn't access my DSL modem!

We should make DOCKER_NETWORK_SUBNET configurable so that developers can change it so it doesn't conflict with their local network. We should also set it to a less common private address range. 192.168.0.0/16 is used by default by pretty much every home router. 10.0.0.0/8 is pretty common in businesses. I think we should default to 172.16.0.0/12.

henare avatar Aug 17 '16 09:08 henare

Oops. Sorry!

mlandauer avatar Aug 19 '16 10:08 mlandauer