Multi-channel EPG button `0` action changed
! Before you log an issue, have you updated to the most recent version? It's possible the issue may have already been fixed.
Describe the bug / Actual behaviour:
Multi-channel EPG button 0 now goes to top item of current page
Expected behaviour:
Pressing 0 should/used to go to very first item on first page
Has this issue started to happen just recently? Yes
To reproduce: Steps to reproduce the behavior:
- Open multi-channel EPG
- Scroll down a few pages
- Scroll down a few items on that page
- Press
0
Screenshots N/A
Image/Box Model (please complete the following information):
- Version: 7.3
- BoxModel: Mut@nt HD51
Additional context N/A
I think this belongs to this issue. (New code -> same root/issue) On first page, usage of Key/Button 2 should first jump to first channel then maybe to previous page (at end of list but i think this is new) Bad is, you are on row 5, use Key 2 and then you are at the end of the list with only 2 rows, now go to next page and you are/stay on row 2...
Button mappings in various places have Go to top of current page and Go to start of list, as well as Page up and Page down (although not worded exactly like that).
0 should Go to start of list in the multi-channel EPG.
In the channel list as well as multi-channel EPG, scrolling page-by-page keeps the selection on the Xth row, until the start or end of list which then sets the selection to the first row or row position of the last item in the list... which I think is standard/expected practice in various user interfaces 🤔
Issue doesn't seem to be in EpgSelection.py - the following relevant blocks haven't been changed in years. Perhaps it's to do with self["list"].instance.moveTop?
https://github.com/openatv/enigma2/blob/0362939424c4b1a883c0a15c0db83956776ebc81/lib/python/Screens/EpgSelection.py#L305
https://github.com/openatv/enigma2/blame/0362939424c4b1a883c0a15c0db83956776ebc81/lib/python/Screens/EpgSelection.py#L1956
https://github.com/openatv/enigma2/blame/0362939424c4b1a883c0a15c0db83956776ebc81/lib/python/Screens/EpgSelection.py#L693
Ohhhhhhhhh... I've tried
def toTop(self):
self["list"].setCurrentIndex(0)
but that still only brought the cursor to the top of the current page...
The issue didn't exist on or before image dated 2023-06-10
It started happening on or before image dated 2023-07-09
https://github.com/openatv/enigma2/compare/3910720e51fe6006507592b2c71e66b7e36ceddc..23d2bca217cfbb121cd4aac0659d02fa8f81c9ad
Maybe this!?
Maybe this!?
That’s exactly the problem. This change is a massive performance improvement and we need to refactor this completely.
Link #3119