enigma2 icon indicating copy to clipboard operation
enigma2 copied to clipboard

Multi-channel EPG button `0` action changed

Open wedebe opened this issue 2 years ago • 8 comments

! Before you log an issue, have you updated to the most recent version? It's possible the issue may have already been fixed.

Describe the bug / Actual behaviour: Multi-channel EPG button 0 now goes to top item of current page

Expected behaviour: Pressing 0 should/used to go to very first item on first page

Has this issue started to happen just recently? Yes

To reproduce: Steps to reproduce the behavior:

  1. Open multi-channel EPG
  2. Scroll down a few pages
  3. Scroll down a few items on that page
  4. Press 0

Screenshots N/A

Image/Box Model (please complete the following information):

  • Version: 7.3
  • BoxModel: Mut@nt HD51

Additional context N/A

wedebe avatar Aug 11 '23 15:08 wedebe

I think this belongs to this issue. (New code -> same root/issue) On first page, usage of Key/Button 2 should first jump to first channel then maybe to previous page (at end of list but i think this is new) Bad is, you are on row 5, use Key 2 and then you are at the end of the list with only 2 rows, now go to next page and you are/stay on row 2...

GhostofGeeeee avatar Oct 08 '23 11:10 GhostofGeeeee

Button mappings in various places have Go to top of current page and Go to start of list, as well as Page up and Page down (although not worded exactly like that).

0 should Go to start of list in the multi-channel EPG.

In the channel list as well as multi-channel EPG, scrolling page-by-page keeps the selection on the Xth row, until the start or end of list which then sets the selection to the first row or row position of the last item in the list... which I think is standard/expected practice in various user interfaces 🤔

wedebe avatar Oct 08 '23 22:10 wedebe

Issue doesn't seem to be in EpgSelection.py - the following relevant blocks haven't been changed in years. Perhaps it's to do with self["list"].instance.moveTop?

https://github.com/openatv/enigma2/blob/0362939424c4b1a883c0a15c0db83956776ebc81/lib/python/Screens/EpgSelection.py#L305

https://github.com/openatv/enigma2/blame/0362939424c4b1a883c0a15c0db83956776ebc81/lib/python/Screens/EpgSelection.py#L1956

https://github.com/openatv/enigma2/blame/0362939424c4b1a883c0a15c0db83956776ebc81/lib/python/Screens/EpgSelection.py#L693

wedebe avatar Oct 12 '23 21:10 wedebe

Ohhhhhhhhh... I've tried

	def toTop(self):
		self["list"].setCurrentIndex(0)

but that still only brought the cursor to the top of the current page...

wedebe avatar Oct 12 '23 22:10 wedebe

The issue didn't exist on or before image dated 2023-06-10

It started happening on or before image dated 2023-07-09

https://github.com/openatv/enigma2/compare/3910720e51fe6006507592b2c71e66b7e36ceddc..23d2bca217cfbb121cd4aac0659d02fa8f81c9ad

wedebe avatar Oct 12 '23 22:10 wedebe

Maybe this!?

GhostofGeeeee avatar Oct 13 '23 08:10 GhostofGeeeee

Maybe this!?

That’s exactly the problem. This change is a massive performance improvement and we need to refactor this completely.

jbleyel avatar Oct 13 '23 09:10 jbleyel

Link #3119

jbleyel avatar Nov 07 '23 16:11 jbleyel