enigma2 icon indicating copy to clipboard operation
enigma2 copied to clipboard

Cleanup About.py

Open jbleyel opened this issue 2 years ago • 2 comments

These functions can be moved from About.py to SystemInfo.py or any other module. getIfConfig (_ifinfo) getChipSetString getFlashDateString getBuildDateString getGStreamerVersionString getFFmpegVersionString getCPUSerial getCPUInfoString (_getCPUSpeedMhz) getSystemTemperature getChipSetString getCPUBrand getCPUArch getFlashType getPythonVersionString getBoxUptime getGlibcVersion getGccVersion getopensslVersionString

These functions can be removed from About.py getIfTransferredData getUpdateDateString getDriverInstalledDate

These functions needs to stay getVersionString getImageVersionString getEnigmaVersionString getKernelVersionString GetIPsFromNetworkInterfaces

jbleyel avatar Apr 30 '23 08:04 jbleyel

I think image version/software-specific data would be more intuitive perhaps if kept in About.py, separate from hardware values? Namely

getFlashDateString getBuildDateString getGStreamerVersionString getFFmpegVersionString getPythonVersionString getGlibcVersion getGccVersion getopensslVersionString

...although maybe that opens up thoughts of a HardwareInfo & SoftwareInfo file split 🤔😬

wedebe avatar May 01 '23 10:05 wedebe

We are trying to clean up the code and reduce the module count. Another aspect of the clean up is to reduce the number of places people need to edit to maintain the code. SystemInfo.py is not just for hardware. It is intended to hold all things specific to hardware or software such that as much of the rest of the Enigma2 code can become common and hardware abstracted for all systems.

IanSav avatar May 02 '23 05:05 IanSav