enigma2 icon indicating copy to clipboard operation
enigma2 copied to clipboard

[File Commander] Status bar notification style

Open wedebe opened this issue 2 years ago • 11 comments

! Before you log an issue, have you updated to the most recent version? It's possible the issue may have already been fixed.

Describe the bug / Actual behaviour: File Commander uses a non-standard (and, tbh, ugly) method of notifying users of actions performed. yuk-screenshot_20230426050356

Expected behaviour: 20230426133503

Has this issue started to happen just recently? No, it has been a problem for quite a while.

To reproduce: Steps to reproduce the behavior:

  1. Open File Commander
  2. Delete a file

Screenshots See above

Image/Box Model (please complete the following information):

  • Version: 7.2 latest
  • BoxModel: Mut@nt HD51

Additional context n/a

wedebe avatar Apr 26 '23 12:04 wedebe

This is by purpose because the Messagebox is annoying here. That’s why we have implemented the status bar.

jbleyel avatar Apr 26 '23 13:04 jbleyel

When we were developing the code we found all the pop up windows to be intrusive. Further the windows needed to be acknowledged which required extra button clicks. If we used timed popups they were either closed too fast to read the message or stayed on screen for too long and interrupted the work flow.

Give this explanation, if you still think this is wrong (is a bug) then I would be interested to see how you would deal with this issue.

IanSav avatar Apr 26 '23 14:04 IanSav

Ok, not a bug but certainly needs improvement. The Status Bar component could really do with some input from the designer(s) of MetrixHD skin. Even the position doesn't seem... right. Perhaps...

  • moving it to between the paths and column headers
  • re-using the highlight colouration (in this case, white on blue background)
  • drop the drop-shadow
  • and re-using the Message Box icon per success/error staus would be a more pleasing-to-the-eye approach?

wedebe avatar Apr 28 '23 11:04 wedebe

The new status bar is fully skinable.

-> https://github.com/openatv/MetrixHD/blob/7.1/usr/share/enigma2/MetrixHD/skinfiles/skin_plugins.xml#L2903 -> https://github.com/openatv/MetrixHD/blob/7.1/usr/share/enigma2/MetrixHD/skinfiles/skin_plugins.xml#L2951

jbleyel avatar Apr 28 '23 11:04 jbleyel

Ok, not a bug but certainly needs improvement. The Status Bar component could really do with some input from the designer(s) of MetrixHD skin. Even the position doesn't seem... right. Perhaps...

  • moving it to between the paths and column headers

This is not free space. This space is for long file paths. Though you can put it there in your own skin if you like.

  • re-using the highlight colouration (in this case, white on blue background)

This is skin-able.

  • drop the drop-shadow

This is skin-able.

  • and re-using the Message Box icon per success/error staus

This is not so easy as this is a text only widget.

would be a more pleasing-to-the-eye approach?

@jbleyel and I workshopped a number of ideas before deciding that this was the best option of all the ideas we came up with. That said, if you want to have all the pop ups then this could be added. I would insist it be optional as I can assure you that all the pop ups generated will drive you to distraction.

IanSav avatar Apr 28 '23 15:04 IanSav

I guess the closest equivalent from a web design world would be the MUI snackbar: https://m2.material.io/components/snackbars

...in particular placement. My biggest issue really is the gawdawful yellow and text shadow!

wedebe avatar Apr 28 '23 22:04 wedebe

Are there other variations (colours) for, eg. errors?

wedebe avatar Apr 29 '23 10:04 wedebe

There is only one status bar color without any icon in the current skin. We need to change the code and all skins if you wanna have different colors and different icons.

jbleyel avatar May 04 '23 19:05 jbleyel

I don't like if I select the last file and I get the status bar because now the selection is hidden. At this moment I think the status bar on first row will be better becasue there is often < xxx >. I will try this...

GhostofGeeeee avatar Jan 25 '25 17:01 GhostofGeeeee

The status bar has a timeout of 3 seconds (default) .. So what's the problem.

jbleyel avatar Jan 26 '25 18:01 jbleyel

The status bar has a timeout of 3 seconds (default) .. So what's the problem.

The problem is having to wait 3 seconds to take any yaction on the last file in the list. There should instead be padding at the bottom of the list to ensure all items are always kept visible when the status bar shows.

wedebe avatar Jan 27 '25 02:01 wedebe