openaq-fetch
openaq-fetch copied to clipboard
openaq
Conflicting EEA Sources
There are Pull Requests up to fetch EEA Direct data for all countries, with exception of:
- gb - united kingdom
- nl - netherlands
- no - norway
- pl - poland
- se - sweden
These countries have working adapters that fetch data from a different source. We should assess whether it makes sense to substitute these for the EEA Direct adapter.
@RocketD0g
I tend to think replacing all of them w/ the EEA adapter might be cleanest in the long-term, even if they don't fully overlap with one another (or even if the EEA data has fewer data points). That said: If the EEA adapter for one of those countries doesn't report any data currently for some reason, then I'd tend to want to stay with the current adapter for that country for now.
I assume changing from the current country adapter to the EEA may cause potential weirdness with the way some stations are saved and would need to be dealt with in the near term to reconcile the differences (e.g. the station name is slightly different in the EEA setting than the current adapter)? And guessing it'd be difficult to fully assess that before doing the switch too?
@jflasher? Others?
e.g. the station name is slightly different in the EEA setting than the current adapter
Because of the way that the EEA Direct adapter determines the location name currently (it uses the unique station_code), we can assume it will be completely different from what it is now.
Heh heh, sounds like we can fully assess that then. :)
Just chatted IRL with @jflasher: His sentiments are same for favoring going to EEA adapters from other country-specific adapters (as long as they are putting out some data).
Whenever we do that, it could be a project for someone perhaps in the community to see what stations are not included in the EEA adapter but shared by that original data source we used and for them to contact the EEA or the other originating data source to help bring those stations up to the EEA system.
I know everyone "loves" these kinds of questions but: any news / decisions on this front?
Hi @d4rky-pl, I do love these questions! :grin: I'm honestly not sure what the current state of this is. It'd be very helpful is someone could reset our information on this question. This list of current countries we're getting from EEA is at https://github.com/search?utf8=%E2%9C%93&q=eea-direct+path%3A%2Fsources&type=Code&ref=advsearch&l=&l=, looks like it's 22 countries. In cases where it wouldn't stop the data from coming in completely (i.e., a country just doesn't seem to be reporting to EEA), it'd be great to use EEA to simplify the overall number of adapters we need.
The country I'm interested in (Poland) is available in the EEA dataset so it shouldn't be that hard but I'm afraid I have no idea how the app itself works (and I'm afraid it's too big for me to dive into it at the moment) so can't really help with a PR :)
I know @michalcz has been looking at Polish data as well. Not sure how it relates to the data coming in from EEA.
@d4rky-pl, I'm writing an adapter that will use the data directly from Główny Inspektorat Ochrony Środowiska (http://powietrze.gios.gov.pl/pjp/content/api). I do believe the EEA data is more or less the same, but with some extra latency, since the Polish project was partially funded by EEA.
I'll be publishing the Polish branch in my fork this or next week - if you'd like to test, drop me a note. You should be able to see my email on my gh profile. :)
