openandroidinstaller icon indicating copy to clipboard operation
openandroidinstaller copied to clipboard

Magisk support

Open Gooberpatrol66 opened this issue 2 years ago • 12 comments

Can this tool be used to more easily install Magisk on top of LineageOS (or other ROMs)?

Gooberpatrol66 avatar Mar 01 '23 22:03 Gooberpatrol66

Hey, thanks for your interest in the project! :) I have only very limited experience with Magisk since I usually don't root and I'm not super aware of the installation process. Can Magisk be sideloaded as a flashable zip or need some other things need to be patched?

tsterbak avatar Mar 02 '23 06:03 tsterbak

yep, most people flash the apk or rename it to .zip and flash it (in case the twrp version is too old) the recommended method is to patch the boot.img using the app, but no one really does that.

SirRGB avatar Mar 02 '23 20:03 SirRGB

Yes, flashing Magisk zip as "addon" works (used OrangeFox on lavender, see #218 and #222)

ghost avatar Aug 02 '23 11:08 ghost

I used the "app patches boot.img" way and it also worked fine...

@anon1892 Does the addon flashing also work for twrp or only for orangefox?

MagicLike avatar Aug 02 '23 17:08 MagicLike

zip flashing is not specific to OrangeFox (which is based on TWRP), so it should work

ghost avatar Aug 02 '23 17:08 ghost

操作不来啊蛋蛋

Doctorlao avatar Sep 29 '23 06:09 Doctorlao

The first step is done and will be included in 0.52. Flashing magisk as addon still requires renaming the .apk to .zip or simply ignoring the .zip suffix when selecting the file.

https://github.com/openandroidinstaller-dev/openandroidinstaller/commit/6859a5ebb299aac3e546823a4f2967ee2e56bd31

SirRGB avatar Jan 11 '24 00:01 SirRGB

Is there any progress on this? I installed LineageOS 20 on my Galaxy S6 yesterday (SM-G920F) and now I want to root it

tim-gromeyer avatar Feb 07 '25 10:02 tim-gromeyer

I cannot guarantee that it works, since I did not test it. But if you sideload magisk as a zip addon, people (also in this thread) reported that it works.

Please try it and report back if it worked for you :)

tsterbak avatar Feb 07 '25 10:02 tsterbak

Yes, that worked. Can we somehow automate this process into OpenAndroidInstaller?

tim-gromeyer avatar Feb 09 '25 10:02 tim-gromeyer

Yes, that worked. Can we somehow automate this process into OpenAndroidInstaller?

Great that it worked!

I'm not sure if I want to automate it more at the moment since I have no experience with Magisk. Are there official distributions that work on every device? Then we could think about integrating this. Otherwise, the best thing would be to have a short tutorial on how do do it in the repo or in the installer, if you want to use Magisk and root. What do you think?

tsterbak avatar Feb 09 '25 12:02 tsterbak

Imo Magisk shouldnt be installable via a checkbox in the oai, because some devices dont handle it very well and might fail to boot. Also Magisk is aimed toward a little more experienced users, which I dont think this tool is aimed for, since you can shoot urself into ur own foot easily and it will cause some security related apps to fail if not hidden properly, tho that also depends on the rom itself...

SirRGB avatar Feb 09 '25 12:02 SirRGB