iis icon indicating copy to clipboard operation
iis copied to clipboard

Consider making an affiliation matching tests logging outcome on TRACE level visible in console

Open marekhorst opened this issue 1 year ago • 2 comments

Currently the information generated by the AffOrgMatchVoterStrengthEstimatorAndTest is logged on the TRACE level which is not being logged by default. This makes working on reestimation of the voters' strength rather difficult and having this logged during running the tests would be rather beneficial.

The file already created to cover quite specific logging requirements of the affiliation matching module:

iis-wf/iis-wf-affmatching/src/test/resources/log4j.properties

currently does not enable AffOrgMatchVoterStrengthEstimatorAndTest class to log the information on the TRACE level.

marekhorst avatar Nov 18 '24 15:11 marekhorst

Adding the following line:

log4j.logger.eu.dnetlib.iis.wf.affmatching.match.voter=TRACE

in the iis-wf/iis-wf-affmatching/src/test/resources/log4j.properties file will solve that issue.

It will be solved assuming the .classpath file created for Eclipse environment within the iis-wf-affmatching module has this location defined prior to the location of the default iis-common/src/main/resources/log4j.properties file which is meant to be used in a production cluster environment. The order of loading log4j.properties files determines which log4j configuration will be taken into account.

marekhorst avatar Nov 18 '24 15:11 marekhorst

I proved this to be working in a local environment it just needs to be decided if it should be a default configuration. One obvious drawback is having test logs polluted with this additional information which is not very useful when running an automated tests suite.

marekhorst avatar Nov 18 '24 15:11 marekhorst