whisper icon indicating copy to clipboard operation
whisper copied to clipboard

Add support for AMD GPU (ROCm Platform)

Open yaomingamd opened this issue 1 year ago • 9 comments

PyPI name of openAI Triton for ROCm Platform is pytorch-triton-rocm, so that modify setup.py to install correct Triton package for ROCm platform. Also modify README.md to add instruction to install on ROCm Platform. Tested on ROCm Platform with AMD GPUs.

yaomingamd avatar Jun 28 '23 16:06 yaomingamd

What OS is this for?

KnechtNoobrecht avatar Sep 05 '23 11:09 KnechtNoobrecht

OS is Linux

yaomingamd avatar Sep 05 '23 13:09 yaomingamd

Instead of using environment variable, i suggest to use extras_require as could be see in here. Another option is to automatically detect if it is using ROCm platform.

threeal avatar Sep 06 '23 02:09 threeal

Based on the suggestion, remove environmental variable and add function to detect ROCm Platform automatically.

yaomingamd avatar Sep 16 '23 02:09 yaomingamd

Will this work with generic AMD gpus, ie newer integrated gpus?

x86Gr avatar Sep 19 '23 19:09 x86Gr

Will this work with generic AMD gpus, ie newer integrated gpus?

@x86Gr This is the list of supported GPUs

https://rocm.docs.amd.com/en/latest/release/gpu_os_support.html

glangford avatar Sep 19 '23 19:09 glangford

@x86Gr @glangford This link should work: https://rocm.docs.amd.com/en/latest/release/gpu_os_support.html#linux-supported-gpus

yaomingamd avatar Sep 20 '23 02:09 yaomingamd

Any particular reason the PR only selected a subset of supported AMD GPUs?

gfx1030 or gfx1100 appear to be missing

ic4-y avatar Nov 02 '23 13:11 ic4-y

@vadimkantorov @Reviewer of this PR. Is there any update about review to merge this PR? Is there anything I can help to speed up the process? Thanks!

yaomingamd avatar Jan 17 '24 20:01 yaomingamd