openai-cookbook icon indicating copy to clipboard operation
openai-cookbook copied to clipboard

Bug: Test and training data the same in examples/Customizing_embeddings.ipynb

Open dpsimpson opened this issue 1 year ago • 1 comments

I'm pretty sure there's a typo in the optimize_matrix routine in block 10 of the customizing_embeddings notebook.

The code

e1_train, e2_train, s_train = tensors_from_dataframe(
        df[df["dataset"] == "train"], "text_1_embedding", "text_2_embedding", "label"
    )
    e1_test, e2_test, s_test = tensors_from_dataframe(
        df[df["dataset"] == "train"], "text_1_embedding", "text_2_embedding", "label"
    )

should probably be

e1_train, e2_train, s_train = tensors_from_dataframe(
        df[df["dataset"] == "train"], "text_1_embedding", "text_2_embedding", "label"
    )
    e1_test, e2_test, s_test = tensors_from_dataframe(
        df[df["dataset"] == "test"], "text_1_embedding", "text_2_embedding", "label"
    )

dpsimpson avatar Mar 06 '23 09:03 dpsimpson

Wow. Great catch. I'll fix this.

ted-at-openai avatar Mar 06 '23 17:03 ted-at-openai

Fixed here: https://github.com/openai/openai-cookbook/pull/236

ted-at-openai avatar Mar 17 '23 02:03 ted-at-openai