openai-cookbook icon indicating copy to clipboard operation
openai-cookbook copied to clipboard

Fix example to use the correct embedding model used in the sample data

Open oshea00 opened this issue 5 months ago • 2 comments

Summary

The embedding model used in the example does not match the embedding model used to create the sample data which is uploaded to Elasticsearch. This causes incorrect results to be returned from Elasticsearch.

Motivation

For the example to work as expected, the documents returned in the KNN search will not match unless the search query is embedded with the model used to index the articles. It's probably better for the example to work than to return confusing results.

oshea00 avatar Jan 28 '24 00:01 oshea00

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Apr 03 '24 01:04 github-actions[bot]

This MR is a typo fix. It will help others save the time I lost. It looks like a lot of MRs are "stacking up" here, but on the off chance someone is looking this one over, here's another comment to keep it alive (as requested). Perhaps this "one-liner" could be merged easily enough?

oshea00 avatar Apr 03 '24 03:04 oshea00