DALL-E icon indicating copy to clipboard operation
DALL-E copied to clipboard

Published 20 hours ago • verified publisher icon openai

Update utils.py

Open NomsterDude opened this issue 2 years ago • 6 comments

Removed the need to import math by implementing another method to calculate a sqrt.

NomsterDude avatar Jun 10 '22 03:06 NomsterDude

But why?

sleroq avatar Jun 11 '22 08:06 sleroq

But why?

he wanted to contribute to this code someway hahaha

zaaachos avatar Jun 11 '22 10:06 zaaachos

But why?

Removes the need for an import and improves efficiency, even if not by much.

NomsterDude avatar Jun 11 '22 15:06 NomsterDude

You didn't suggest any changes.

NomsterDude avatar Jun 15 '22 16:06 NomsterDude

Hi guys, I was just looking some PR's to see if there was any new improvement and found this. I am not sure but I believe that math.sqrt gives you and porper error if the sqrt is negative, and @NomsterDude 's changes could fail withou and proper error. Hope I've helped 👍🏼

gabrielnoal avatar Jul 29 '22 14:07 gabrielnoal

Hi guys, I was just looking some PR's to see if there was any new improvement and found this. I am not sure but I believe that math.sqrt gives you and porper error if the sqrt is negative, and @NomsterDude 's changes could fail withou and proper error. Hope I've helped 👍🏼

Good to know! Thanks for the reply!

NomsterDude avatar Aug 05 '22 17:08 NomsterDude