client icon indicating copy to clipboard operation
client copied to clipboard

Symfony Bundle

Open GromNaN opened this issue 2 years ago • 5 comments

Hi, thank you for this library that is very easy to use.

I created a Symfony bundle by copying things from the Laravel integration. You can find it here: https://github.com/GromNaN/openai-symfony (work in progress).

What do you think of moving this project into the openai-php organisation? It would be good for this project to provide an integration with a 2nd major framework. The bundle is not published on Packagist yet, so that it would be a clean start.

GromNaN avatar Mar 03 '23 21:03 GromNaN

Excellent idea. Just created the repository, and added you as maintainer. Can you make sure the project, structure, coding style, readme, (everything really), looks exactly like the client / laravel integration? Thanks!

  • https://github.com/openai-php/symfony.
  • https://github.com/openai-php/symfony/invitations.

nunomaduro avatar Mar 03 '23 21:03 nunomaduro

Excellent. I'm going to do this right.

GromNaN avatar Mar 03 '23 21:03 GromNaN

Let me know when is ready, and i will review it. ✔️

nunomaduro avatar Mar 03 '23 22:03 nunomaduro

Ready. You can submit on Packagist whenever you want to.

There is a phpstan error that I'll dig with the Symfony team.

GromNaN avatar Mar 03 '23 22:03 GromNaN

Done. So, now I guess we have the HTTP client issue + the tests not passing issue, that's correct?

nunomaduro avatar Mar 04 '23 11:03 nunomaduro

Thank you for the publication on packagist. Tests are green after https://github.com/openai-php/symfony/commit/c7d4a74322f7afd8f83f708ef99bf9b8bb579be0 (and the bundle is working again).

GromNaN avatar Mar 04 '23 20:03 GromNaN

Closing as the bundle have been tagged. Thanks.

GromNaN avatar Mar 10 '23 07:03 GromNaN