pyesridump icon indicating copy to clipboard operation
pyesridump copied to clipboard

add state management to the dumper to ease resumption

Open ramSeraph opened this issue 1 year ago • 4 comments

state can be serialised to disk and used to skip already handled features

Submitting the PR, to see if there is interest in this feature, given the amount of code changes, I wouldn't mind maintaining it separately if it is too much of a review burden.

TODO:

  • [ ] Add tests for the state management code
  • [ ] provide support to specify state file in the cli

ramSeraph avatar Nov 14 '22 10:11 ramSeraph

Existing tests pass, and state management for all modes except the query by geographical extent were used and known to work.

ramSeraph avatar Nov 14 '22 10:11 ramSeraph

An example of usage is here: https://github.com/ramSeraph/esriscraper/blob/main/esriscraper/scrape.py#L14

ramSeraph avatar Nov 14 '22 11:11 ramSeraph

Thanks for submitting this. I'm still thinking about if this is something I want to support in the library directly.

iandees avatar Nov 18 '22 03:11 iandees

I too think a lot of it can be outside the library, but some encapsulation of params for different modes might need to be in the library to support something similar to the cli "start_with" for all modes.

Your call, also not urgent at all :)

ramSeraph avatar Nov 18 '22 08:11 ramSeraph