rapidquilt icon indicating copy to clipboard operation
rapidquilt copied to clipboard

hunks after unusual long hunk are not applied

Open olafhering opened this issue 2 years ago • 2 comments

The attached patch msft-hv-2510-PCI-hv-Make-the-code-arch-neutral-by-adding-arch-spe.patch.gz is not fully applied to openSUSE/kernel-source@c4cee83301d853833c511730b10397d80fd9e1f8.

The hunk up to hv_msi_irq_chip will be applied. The following hunks, starting from hv_pcie_init_irq_domain are not applied anymore.

This might be caused by the fact that hv_msi_domain_ops_get_hwirq was inserted into the middle of the original torvalds/linux@831c1ae725f7d2f8f858b0840692b48e75b49331, just to avoid further backports. But since the hunk is valid, it is not obvious why it would cause issues.

olafhering avatar Oct 14 '22 20:10 olafhering

It turned out, that long hunk had an extra ^ $ at the end. Apparently all tools silently tolerated this.

olafhering avatar Oct 14 '22 20:10 olafhering

Yeah, I can recall that I had a weird feeling about the handling of “noise lines” between hunks and I have even found a TODO item to re-check it against GNU patch behaviour. So, now is the time, I guess.

ptesarik avatar Dec 02 '22 13:12 ptesarik