osem icon indicating copy to clipboard operation
osem copied to clipboard

Old migrations need to have `ActiveRecord::Migration` specified or will raise an error

Open carlosdanielpohlod opened this issue 3 years ago • 5 comments

I'm submitting a ..

  • [ x ] Bug Report
  • [ ] Feature Request

Current behavior: Currently, the specification of ActiveRecord::Migration in old migration files is required but is not specified, so rails db:migrate raises an error

Expected correct behavior:

Steps to reproduce: run rails db:migrate when database is empty

Other information:

carlosdanielpohlod avatar Nov 09 '22 19:11 carlosdanielpohlod

I will take this issue to solve

carlosdanielpohlod avatar Nov 09 '22 19:11 carlosdanielpohlod

See #2665 for a script that automates this.

AndrewKvalheim avatar Nov 09 '22 19:11 AndrewKvalheim

See #2665 for a script that automates this.

You filled some files with the correct version, right? the other ones still do not have the version, can I fill in the others?

carlosdanielpohlod avatar Nov 09 '22 20:11 carlosdanielpohlod

Yes, I skipped the migrations that I wasn’t taking the time to review, but ideally all should have the version specified.

AndrewKvalheim avatar Nov 09 '22 20:11 AndrewKvalheim

Yes, I skipped the migrations that I wasn’t taking the time to review, but ideally all should have the version specified.

Ok

carlosdanielpohlod avatar Nov 09 '22 20:11 carlosdanielpohlod