Surveys during proposal submission

[AndrewKvalheim]

Checklist

• [x] I have read the Contribution & Best practices Guide.
• [x] My branch is up-to-date with the upstream master branch.
• [x] The tests pass locally with my changes.
• [x] I have added tests that prove my fix is effective or that my feature works (if appropriate).
• [ ] I have added necessary documentation (if appropriate).

Short description of what this resolves

SeaGL would like to collect additional information from each speaker at the time of proposal submission. The information is per speaker (not per submission), per conference (the answer may change each year), and specific to our needs (not appropriate for upstreaming). Previously we’d been hard-coding questions into the proposal form—

• SeaGL/osem#4
• SeaGL/osem#24

—but it was suggested that we use the surveys feature for this instead. That would fit our needs well, but “during proposal submission” isn’t one of the available targets.

Changes proposed in this pull request

Add the during_proposal survey target,

and list available surveys on the speaker’s Proposals screen:

Concerns

• Like during_registration, this isn’t actually during proposal submission but immediately after it. Is there a better place or time to display the surveys?
• The list of surveys is currently sparse, has no instructions or explanation, and might be easily overlooked. Can the design be improved?
• This adds a fork in the proposal submission flow, competing with the “complete your proposal” prompt. Which path should we encourage first? Can/should they be combined? After completing one path, is the submitter guided back to the remaining one?
• While our needs are to ask questions of each speaker, this implementation actually asks each submitter. Typically the submitter is the speaker, but this fails to handle the edge cases of multiple speakers or submissions on behalf of a speaker. How might a true per-speaker survey work?

[hennevogel]

Like during_registration, this isn’t actually during proposal submission but immediately after it. Is there a better place or time to display the surveys?

I guess it's called like that because it's not limited to Event submitters. As you can register without submitting an Event...

The list of surveys is currently sparse, has no instructions or explanation, and might be easily overlooked. Can the design be improved?

Always! You need help? 😃

This adds a fork in the proposal submission flow, competing with the “complete your proposal” prompt. Which path should we encourage first? Can/should they be combined? After completing one path, is the submitter guided back to the remaining one?

Why not add the "missing" survey to that nag?

While our needs are to ask questions of each speaker, this implementation actually asks each submitter. Typically the submitter is the speaker, but this fails to handle the edge cases of multiple speakers or submissions on behalf of a speaker. How might a true per-speaker survey work?

Add "roles" (if User.has_submitted_to(@conference) to questions? Or add some 'help' text field to questions that people can use to mark questions for submitters.