osem
osem copied to clipboard
get rid of travel info
I wonder why we want the arrival and departure time of the attendees. In the registration:
After registering:
Should we get rid of this?
Related to https://github.com/openSUSE/osem/issues/2011
@differentreality @ddemaio @bear454 @hennevogel any opinion?
I agree: https://gitlab.com/lfnw/osem/commit/d18cc02f0185df39bb4213d8a63a955dfb433dcb
Want me to submit this as a PR, @Ana06 ?
@bear454
I agree: https://gitlab.com/lfnw/osem/commit/d18cc02f0185df39bb4213d8a63a955dfb433dcb Want me to submit this as a PR, @Ana06 ?
I would suggest we give the rest a bit of time to answer (just in case someone find it useful). If everybody agrees it would be great if you could send a PR :cupid:
This can now be part of surveys anyway.
Part of this, though, is migrating travel details of older conferences into surveys.
We can make this a good first issue
to handle the removal from the view file only. And let the DB fields be handled along with the above mentioned migration.
@differentreality
We can make this a good first issue to handle the removal from the view file only. And let the DB fields be handled along with the above mentioned migration.
well, you need two migrations, right? one data migration to move things around (if needed) and another migration to get rid of those fields. I think all this should be done together and I don't think it is a good candidate for good first issue. We have many small bugs lately anyway that we can label as good first issue.
Right, however, my point was not to split the migrations. I was merely saying we could drop the view files associated with questions, mainly because there are issues with questions, and organizers may or may not be able to see the answers to the questions anyway. Touching tables, migrating data, that's another story.
Duplicate of https://github.com/openSUSE/osem/issues/1263
@bear454 it is clear we want to drop this (and since a lot of time ago seeing #1263). Can you please send that PR? :pray:
@bear454 it is clear we want to drop this (and since a lot of time ago seeing #1263). Can you please send that PR? pray
Sorry for the delay - I kept getting frustrated trying to rebase... finally got through. Tests already passed :heavy_check_mark: :smile:
Completed in #2591