osem icon indicating copy to clipboard operation
osem copied to clipboard

Published 20 hours ago • verified publisher icon openSUSE

get rid of travel info

Open Ana06 opened this issue 5 years ago • 10 comments

I wonder why we want the arrival and departure time of the attendees. In the registration:

image

After registering: image

Should we get rid of this?

Related to https://github.com/openSUSE/osem/issues/2011

Ana06 avatar Feb 19 '19 11:02 Ana06

@differentreality @ddemaio @bear454 @hennevogel any opinion?

Ana06 avatar Feb 19 '19 12:02 Ana06

I agree: https://gitlab.com/lfnw/osem/commit/d18cc02f0185df39bb4213d8a63a955dfb433dcb

bear454 avatar Feb 19 '19 15:02 bear454

Want me to submit this as a PR, @Ana06 ?

bear454 avatar Feb 19 '19 15:02 bear454

@bear454

I agree: https://gitlab.com/lfnw/osem/commit/d18cc02f0185df39bb4213d8a63a955dfb433dcb Want me to submit this as a PR, @Ana06 ?

I would suggest we give the rest a bit of time to answer (just in case someone find it useful). If everybody agrees it would be great if you could send a PR :cupid:

Ana06 avatar Feb 19 '19 16:02 Ana06

This can now be part of surveys anyway.

Part of this, though, is migrating travel details of older conferences into surveys. We can make this a good first issue to handle the removal from the view file only. And let the DB fields be handled along with the above mentioned migration.

differentreality avatar Mar 07 '19 04:03 differentreality

@differentreality

We can make this a good first issue to handle the removal from the view file only. And let the DB fields be handled along with the above mentioned migration.

well, you need two migrations, right? one data migration to move things around (if needed) and another migration to get rid of those fields. I think all this should be done together and I don't think it is a good candidate for good first issue. We have many small bugs lately anyway that we can label as good first issue.

Ana06 avatar Mar 07 '19 10:03 Ana06

Right, however, my point was not to split the migrations. I was merely saying we could drop the view files associated with questions, mainly because there are issues with questions, and organizers may or may not be able to see the answers to the questions anyway. Touching tables, migrating data, that's another story.

differentreality avatar Mar 07 '19 17:03 differentreality

Duplicate of https://github.com/openSUSE/osem/issues/1263

differentreality avatar Apr 29 '19 18:04 differentreality

@bear454 it is clear we want to drop this (and since a lot of time ago seeing #1263). Can you please send that PR? :pray:

Ana06 avatar Apr 30 '19 08:04 Ana06

@bear454 it is clear we want to drop this (and since a lot of time ago seeing #1263). Can you please send that PR? pray

Sorry for the delay - I kept getting frustrated trying to rebase... finally got through. Tests already passed :heavy_check_mark: :smile:

bear454 avatar Oct 07 '19 21:10 bear454

Completed in #2591

AndrewKvalheim avatar Mar 05 '23 07:03 AndrewKvalheim