[production][] Failed to forward BsRequest: 533014: #<BsRequest:0x00000005a15298> MaintenanceHelper::MissingAction

[mschnitzer]

threw this 0 times

Failed to forward BsRequest: 533014: #<BsRequest:0x00000005a15298> MaintenanceHelper::MissingAction

~See this exception on Errbit~

~See this exception on Errbit~

~See this exception on Errbit~

~See this exception on Errbit~

See this exception on Errbit

[adrianschroeter]

JFYI, these are attempts to create a request when no actual source change exists.

[eduardoj]

New message after #4734 :

Failed to forward BsRequest: 623144, error: MaintenanceHelper::MissingAction, params: <:parameters>"✓", "authenticity_token"=>"B0gD0Q1hJu5qHjIoqVNfZ5gPsRHijBYuQKqSrwpVKZ6NIOxfBTn24jprsghkDLIX/xoKooyEtbJa6Ym9eGG3GQ==", "reason"=>"This is right", "number"=>"623144", "accepted"=>"Accept request", "forward_devel_0"=>"openSUSE:Factory_#_python-acme", "controller"=>"webui/request", "action"=>"changerequest"} permitted: false>

~~See this exception on Errbit~~

[bgeuken]

Note that this is not an error caused by a bug, but means that the diff between target and source is empty. This can happen when the devel project (the one we forward to) has already the changes that we try to send.

We just don't check this before sending it to errbit.

[hennevogel]

Okay I guess the solution is then to not send the exceptions that we know are ok and also show the user an understandable message.

[bgeuken]

Right.

For the other issue the error message seems already to be fine. So there we just have to identify when we not have to send it to errbit.

Failed to forward BsRequest: 660335, error: The target project openSUSE:Leap:42.1:NonFree is not accepting requests because: Please submit to openSUSE:Factory:NonFree or openSUSE:Leap:42.1:Update:NonFree

[danidoni]

More occurrences: ~https://errbit.opensuse.org/apps/5620ca2bdc71fa00b1000000/problems/6322fd6a84bf46052de96735~

[bmwiedemann]

~https://errbit.opensuse.org/apps/5620ca2bdc71fa00b1000000/problems/648836e484bf46054c5b683f~ seems related, though the underlying reason for the reject is different:

Failed to forward BsRequest: 1092810, error: The target project openSUSE:Backports:SLE-15-SP5:Update is a maintenance release project, a submit self is not possible, please use the maintenance workflow instead., params: #<ActionController::Parameters {"authenticity_token"=>"xxx", "number"=>"1092810", "reason"=>"", "forward-0"=>"openSUSE:Backports:SLE-15-SP5:Update_#_monitoring-plugins-zypper", "accepted"=>"Accept request", "controller"=>"webui/request", "action"=>"changerequest"} permitted: false>

[eduardoj]

I unmerged the exceptions in Errbit and merged it back only with groups of similar errors.

https://errbit.opensuse.org/apps/5620ca2bdc71fa00b1000000/problems/64b8d53e84bf464d43872cd4