open-build-service icon indicating copy to clipboard operation
open-build-service copied to clipboard

Published 20 hours ago • verified publisher icon openSUSE

Allow setting logo in the admin config

Open hellcp-work opened this issue 10 months ago • 2 comments

Lets you change the logo in the frontend Screenshot from 2024-04-17 12-48-36

For reviewers: https://obs-reviewlab.opensuse.org/hellcp-work-logo-upload-ui/configuration

hellcp-work avatar Apr 17 '24 10:04 hellcp-work

:warning: Please make sure the migration is shipped in an independent Pull Request. :warning: :heavy_check_mark: You can include schema changes, annotations and validations for consistency but :x: avoid committing other changes with it.

github-actions[bot] avatar Apr 17 '24 10:04 github-actions[bot]

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-logo-upload-ui

obs-bot avatar Apr 26 '24 14:04 obs-bot

@hellcp-work I get an error when I try to update the logo

@krauselukas, the error was related to the cache. I added a couple of commits. It should work now.

Just a couple of things:

  • Will we provide a way to reset the image to the default?
  • I tried to upload an SVG file and it didn't work.

eduardoj avatar Jun 10 '24 06:06 eduardoj

Just a couple of things:

  • Will we provide a way to reset the image to the default?

I have to have a look how to go about this

  • I tried to upload an SVG file and it didn't work.

https://github.com/rails/rails/issues/34665#issuecomment-445888009, though we can always overwrite this behavior, if we are sure we don't start using activestorage for user submitted content at any point

hellcp-work avatar Jun 10 '24 07:06 hellcp-work