open-build-service
open-build-service copied to clipboard
Split out binary methods out of PackageController
I started working on this because of filelist changes. I will need to add some ajax methods, for handling data from the backend there, but package controller is already overloaded, so I decided to split it up and move all of the relevant methods into another controller. There are still a few failing tests, because of concerns handling them for some reason, but otherwise things should be working
Could you split this PR in smaller ones? This would help with reviewing the changes. Like the changes from Webui::Packages::BinariesHelper
could be in their own PR. For the rest, I don't know since I didn't look at all the changes in details, 39 changed files in a PR is simply too much to review.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.10%. Comparing base (
81eca94
) to head (2ab3cb4
). Report is 1232 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #13564 +/- ##
==========================================
+ Coverage 86.89% 87.10% +0.21%
==========================================
Files 778 778
Lines 25719 25719
==========================================
+ Hits 22348 22403 +55
+ Misses 3371 3316 -55
A small note on the spec: its former name meant that it was never actually called, I revived it from the dead, so don't be surprised by the changes to the existing code
Followed up by #15750, #15746 and #15752